unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gerry Agbobada <gagbobada@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Question about composite.c
Date: Tue, 21 Jan 2020 21:15:59 +0200	[thread overview]
Message-ID: <83muagvcwg.fsf@gnu.org> (raw)
In-Reply-To: <CAHhDRB9bdZF-tbJtym3Bhay394UshiR0_Qqhk0NJyhpcCrvGBA@mail.gmail.com> (message from Gerry Agbobada on Tue, 21 Jan 2020 19:57:07 +0100)

> From: Gerry Agbobada <gagbobada@gmail.com>
> Date: Tue, 21 Jan 2020 19:57:07 +0100
> Cc: emacs-devel@gnu.org
> 
> Therefore, the main goal was to "catch common programming ligatures
> starting with ?*"

Can you show examples of those, if not their exhaustive list?

> > Also, why did you need to use a separate char-table instead of
> > composition-function-table?
> 
> I used another char-table so the variable is easily accessible to modify
> parts of it. Then again, maybe a poor design decision, but just a design
> decision.

I don't see why it would be easier to access/modify a separate table.

> > It's not just an empty string, it's a _unibyte_ string.  How did that
> > happen?
> 
> That's the main part I was trying to understand, since I could not
> reproduce it in an easy way, I was wondering if an empty string can be
> unibyte or multibyte. I have my answer now :)

If you post a complete reproduction recipe, starting from "emacs -Q",
perhaps I will be able to help you understand what is the immediate
cause of the problem.

> > There's no problem with empty strings here, as long as they are
> > multibyte.
> 
> That the main point I don't understand : is there a way to mark an empty
> string as a multibyte string ?

We could look into that, but why would an empty string end up in
composition-get-gstring anyway? there's no meaningful way of composing
such a string.

> At least now I know I can continue investigating on the elisp side, thanks for
> your answers !

I think the important part is to understand why Emacs is trying to
compose an empty string.



  reply	other threads:[~2020-01-21 19:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 22:17 Question about composite.c Gerry Agbobada
2020-01-21 18:15 ` Eli Zaretskii
2020-01-21 18:57   ` Gerry Agbobada
2020-01-21 19:15     ` Eli Zaretskii [this message]
2020-01-22  8:55       ` Gerry Agbobada
2020-04-14 22:43         ` Gerry Agbobada
2020-04-15  1:10           ` Noam Postavsky
2020-04-15  7:39             ` Gerry Agbobada
2020-04-25 12:44           ` Eli Zaretskii
2020-04-25 13:06             ` Gerry Agbobada
2020-04-25 13:29               ` Gerry Agbobada
2020-04-25 13:53                 ` Gerry Agbobada
2020-04-25 15:23                   ` Eli Zaretskii
2020-04-25 15:32                     ` Gerry Agbobada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83muagvcwg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gagbobada@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).