From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 13:11:40 +0300 Message-ID: <83mu11c78j.fsf@gnu.org> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <83blhhdy3w.fsf@gnu.org> <87d01xghmt.fsf@gmail.com> <83sgatc8er.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, spacibba@aol.com, emacs-devel@gnu.org, casouri@gmail.com, juri@linkov.net To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 12:13:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPNUO-0009Pa-NL for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 12:13:04 +0200 Original-Received: from localhost ([::1]:60066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPNUN-0006Sb-Oq for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 06:13:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPNT5-0005b2-Fs for emacs-devel@gnu.org; Mon, 05 Oct 2020 06:11:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55890) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPNT3-00057g-E8; Mon, 05 Oct 2020 06:11:41 -0400 Original-Received: from [176.228.60.248] (port=4623 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPNT2-0003tI-QI; Mon, 05 Oct 2020 06:11:41 -0400 In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Mon, 5 Oct 2020 10:57:35 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257098 Archived-At: > From: João Távora > Date: Mon, 5 Oct 2020 10:57:35 +0100 > Cc: Gregory Heytings , Ergus , Juri Linkov , > Yuan Fu , emacs-devel > > > Or a lot of completion candidates. > > That's odd, I've been C-x C-f'ing to directories with "a lot" of files > and I don't notice any problems. What size of "lot" did you have in > mind? More than can be displayed, one candidate on each line, by the frame's dimensions, I guess. > Make sense. I do notice some truncation in the candidates in this new > vertical mode I've been trying for a day or so, but I expect truncation of > candidates anyway, so I haven't missed the feature of being shown > explicitly that truncation is happening. Anyway, whoever is making > this truncation happen (display engine?) should be the responsible for > showing that warning hint. I don't see why it should be related to > "candidates" or completion at all. The truncation is done by icomplete, not by the display engine. The "warning" is supposed to be in the form of the ellipsis displayed after the last candidate that is shown. > Though maybe the responsible for the truncation can provide a > way (a hook, a variable, a function?) for the user of the minibuffer to select > the appropriate hint. My point here is that this variable/function shouldn't > be called icomplete-truncation-hint, but rather mini-window-truncation-hint. The code which displays the min-window is more-or-less the generic Emacs window-display code, it doesn't care that not all of the stuff fits in the window. If an application wants to fit the buffer in the window, or display some hint about truncation, it's the application's business to do these things.