From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Merging the pgtk branch Date: Mon, 02 Aug 2021 14:49:37 +0300 Message-ID: <83mtq0m5gu.fsf@gnu.org> References: <835ywpo8ar.fsf@gnu.org> <20210802.013859.2264148309496126056.masm@luna.pink.masm11.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuuki Harano Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 02 13:50:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAWSw-0007ck-EW for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Aug 2021 13:50:42 +0200 Original-Received: from localhost ([::1]:36934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAWSv-0005nK-0L for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Aug 2021 07:50:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAWS4-0004t8-4d for emacs-devel@gnu.org; Mon, 02 Aug 2021 07:49:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41386) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAWS2-0000UL-Ir; Mon, 02 Aug 2021 07:49:46 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAWS2-0002en-5C; Mon, 02 Aug 2021 07:49:46 -0400 In-Reply-To: <20210802.013859.2264148309496126056.masm@luna.pink.masm11.me> (message from Yuuki Harano on Mon, 02 Aug 2021 01:38:59 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271938 Archived-At: > Date: Mon, 02 Aug 2021 01:38:59 +0900 (JST) > Cc: emacs-devel@gnu.org > From: Yuuki Harano > > > On Sun, 01 Aug 2021 11:53:16 +0300, > Eli Zaretskii wrote: > >> -install: all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) blessmail install-eln > >> +install: all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) blessmail install-eln install-gsettings-schemas > >> @true > > > > Does this mean gsettings-schemas will be installed by non-PGTK builds > > as well? If not, where are the conditions to prevent that? > > Yes, it is installed if gsettings is enabled, even if non-PGTK builds. Is that useful without the PGTK build? What is that used for? > >> --- a/lisp/server.el > >> +++ b/lisp/server.el > >> @@ -900,12 +900,17 @@ server-create-window-system-frame > >> ) > > > >> (cond (w > >> - (server--create-frame > >> - nowait proc > >> - `((display . ,display) > >> - ,@(if parent-id > >> - `((parent-id . ,(string-to-number parent-id)))) > >> - ,@parameters))) > >> + (condition-case nil > >> + (server--create-frame > >> + nowait proc > >> + `((display . ,display) > >> + ,@(if parent-id > >> + `((parent-id . ,(string-to-number parent-id)))) > >> + ,@parameters)) > >> + (error > >> + (server-log "Window system unsupported" proc) > >> + (server-send-string proc "-window-system-unsupported \n") > >> + nil))) > > > > Why is this change needed? > > emacsclient tries WAYLAND_DISPLAY, and DISPLAY if the first try is failed. > The code catches the display connection failure, and returns the failure > to emacsclient. Hmm... what about window-systems that have neither WAYLAND_DISPLAY nor DISPLAY? will this always fail? I feel that I'm missing something here: why wasn't this needed before? > I'll answer the latter half questions later. TIA.