From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: rudalics@gmx.at, alan@idiocy.org, gregory@heytings.org,
mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org
Subject: Re: input-pending-p after make-frame-visible
Date: Wed, 20 Oct 2021 21:24:31 +0300 [thread overview]
Message-ID: <83mtn3a71c.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48wE+6kO6H6b_cNqoakaq3rikbxCiHzAXMXvW_K=Oeufuw@mail.gmail.com> (message from Aaron Jensen on Wed, 20 Oct 2021 13:47:57 -0400)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Wed, 20 Oct 2021 13:47:57 -0400
> Cc: martin rudalics <rudalics@gmx.at>, Alan Third <alan@idiocy.org>,
> Gregory Heytings <gregory@heytings.org>, emacs-devel@gnu.org,
> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> > Yes. But the change you propose is in readable_events, a function
> > that has many more callers than just input-pending-p. In particular,
> > one of its callers is kbd_buffer_get_event, which is the API through
> > which Emacs reads all of its input. And now, under some
> > circumstances, that API will ignore some events. That's scary, at
> > least for me.
>
> AFAICT kbd_buffer_get_event calls `readable_events (0)' only, which
> will disregard any of the code I changed or added. The
> READABLE_EVENTS_FILTER_EVENTS must be set for it to come into play.
> Only input-pending-p sets that flag AFAICT.
I don't see how this helps: who will remember that no caller of
readable_events can ever use that flag without invoking this behavior
whose justification we don't understand?
> > No, that must be a variable exposed to Lisp, so users could fiddle
> > with it without rebuilding.
>
> Ah, I believe that variable exists already and can affect everything I
> changed other than the reliance on USE_TOOLKIT_SCROLL_BARS:
> while-no-input-ignore-events
No, it must be a separate variable, because it's for people who do
have non-nil while-no-input-ignore-events.
next prev parent reply other threads:[~2021-10-20 18:24 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 17:12 input-pending-p after make-frame-visible Aaron Jensen
2021-09-26 9:11 ` martin rudalics
2021-09-26 14:02 ` Aaron Jensen
2021-09-26 17:50 ` martin rudalics
2021-09-26 23:55 ` Aaron Jensen
2021-09-27 8:51 ` martin rudalics
2021-09-27 9:46 ` Aaron Jensen
2021-09-27 17:14 ` martin rudalics
2021-09-27 18:57 ` Eli Zaretskii
2021-09-28 7:41 ` martin rudalics
2021-09-28 8:06 ` Eli Zaretskii
2021-09-29 9:28 ` martin rudalics
2021-09-29 12:06 ` Eli Zaretskii
2021-09-29 12:16 ` Aaron Jensen
2021-09-29 13:13 ` Eli Zaretskii
2021-09-29 14:16 ` Aaron Jensen
2021-09-29 15:42 ` Eli Zaretskii
2021-10-01 17:31 ` Aaron Jensen
2021-10-01 17:55 ` Eli Zaretskii
2021-10-01 17:57 ` Eli Zaretskii
2021-10-01 18:25 ` Aaron Jensen
2021-10-03 19:33 ` Aaron Jensen
2021-10-03 20:55 ` Aaron Jensen
2021-10-03 21:22 ` Gregory Heytings
2021-10-04 1:38 ` Aaron Jensen
2021-10-04 8:29 ` martin rudalics
2021-10-04 11:04 ` Gregory Heytings
2021-10-04 15:00 ` Aaron Jensen
2021-10-04 20:37 ` Alan Third
2021-10-04 22:12 ` Aaron Jensen
2021-10-05 15:47 ` Alan Third
2021-10-14 11:15 ` Aaron Jensen
2021-10-14 11:32 ` Aaron Jensen
2021-10-14 12:42 ` martin rudalics
2021-10-14 23:04 ` Aaron Jensen
2021-10-15 7:05 ` martin rudalics
2021-10-15 11:30 ` Aaron Jensen
2021-10-16 7:54 ` martin rudalics
2021-10-16 14:16 ` Aaron Jensen
2021-10-16 14:45 ` Aaron Jensen
2021-10-16 15:09 ` Aaron Jensen
2021-10-16 16:49 ` martin rudalics
2021-10-16 17:14 ` Aaron Jensen
2021-10-20 15:27 ` Aaron Jensen
2021-10-20 16:41 ` Eli Zaretskii
2021-10-20 17:15 ` Aaron Jensen
2021-10-20 17:40 ` Eli Zaretskii
2021-10-20 17:47 ` Aaron Jensen
2021-10-20 18:24 ` Eli Zaretskii [this message]
2021-10-20 18:55 ` Aaron Jensen
2021-10-20 19:04 ` Eli Zaretskii
2021-10-20 20:00 ` Aaron Jensen
2021-10-21 6:02 ` Eli Zaretskii
2021-10-21 6:58 ` YAMAMOTO Mitsuharu
2021-10-21 7:47 ` Eli Zaretskii
2021-10-21 11:25 ` Aaron Jensen
2021-10-21 11:33 ` Aaron Jensen
2021-10-21 12:40 ` Stefan Monnier
2021-10-21 13:44 ` Eli Zaretskii
2021-10-21 14:07 ` Aaron Jensen
2021-10-21 17:36 ` Eli Zaretskii
2021-10-21 17:46 ` Aaron Jensen
2021-10-21 18:04 ` Eli Zaretskii
2021-10-21 20:27 ` Aaron Jensen
2021-10-22 2:28 ` Aaron Jensen
2021-10-22 6:10 ` Eli Zaretskii
2021-10-22 13:58 ` Aaron Jensen
2021-10-26 13:23 ` Aaron Jensen
2021-10-26 14:05 ` Eli Zaretskii
2021-10-28 15:51 ` Eli Zaretskii
2021-10-28 18:12 ` Aaron Jensen
2021-10-28 18:20 ` Eli Zaretskii
2021-10-31 10:33 ` Alan Third
2021-10-31 16:42 ` Aaron Jensen
2021-10-21 13:40 ` Eli Zaretskii
2021-10-15 17:32 ` Alan Third
2021-10-15 17:54 ` Stefan Monnier
2021-10-15 18:28 ` Aaron Jensen
2021-10-04 8:28 ` martin rudalics
2021-09-27 19:26 ` Stefan Monnier
2021-09-27 23:02 ` Aaron Jensen
2021-09-28 2:29 ` Aaron Jensen
2021-09-29 5:10 ` Aaron Jensen
2021-09-29 9:28 ` martin rudalics
2021-09-28 5:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mtn3a71c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).