From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making `x-underline-at-descent-line' a face attribute Date: Thu, 06 Jan 2022 22:07:38 +0200 Message-ID: <83mtk87hmd.fsf@gnu.org> References: <87lezt5v7h.fsf.ref@yahoo.com> <87lezt5v7h.fsf@yahoo.com> <83sfu18dao.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 06 21:08:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5Z40-0002rD-04 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 21:08:44 +0100 Original-Received: from localhost ([::1]:35736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Z3y-0006Dw-Bm for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 15:08:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Z2n-0005YZ-83 for emacs-devel@gnu.org; Thu, 06 Jan 2022 15:07:29 -0500 Original-Received: from [2001:470:142:3::e] (port=54452 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Z2m-00052d-Ri; Thu, 06 Jan 2022 15:07:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uyZmVzrjeivQ9UCJCxVPWKxQuSYETufyc7APkLgjm3o=; b=fE0b5ApLsVb/ CcrH3z6MnJLGupDL45CSzS0nQT3Crwtwqm8QX4rKt36vF1+KxQDPauswLF1quuNY5STsjj5odIOr2 0RRkppsucB2pHU6jfX0OypZKiaQ5WIa6CZEvX+QGXabt6UjboAF7aDP5KgIECqmfOijK6gDYbrOwl ki7J+SsjujSMaJilI2IyaTffGxktwDQlxnmC5erZ5w8IRoYFNborIYwCoGyXsH+h9nlbX5s481g30 pDuZ1DCkvsLsaTxnb6QQdOvR8ZQEfgbhWxaHk0/97tNM4MgHPGRypLpu98rr9DfVxfyUcsmsqJw+i Rfrw0yRX98cnG8rWDM32Nw==; Original-Received: from [87.69.77.57] (port=3889 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Z2m-000228-9v; Thu, 06 Jan 2022 15:07:28 -0500 In-Reply-To: (message from Jim Porter on Thu, 6 Jan 2022 09:47:33 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284340 Archived-At: > Cc: luangruo@yahoo.com, emacs-devel@gnu.org > From: Jim Porter > Date: Thu, 6 Jan 2022 09:47:33 -0800 > > On 1/6/2022 12:43 AM, Eli Zaretskii wrote: > >> From: Jim Porter > >> Date: Wed, 5 Jan 2022 21:08:57 -0800 > >> > >> What about enhancing the :box attribute further to allow different > >> widths (and possibly colors) for each of the 4 sides? > > > > The width part is already supported. We could make the value of > > :color be a cons cell as well, if that is useful (is it?) > > Looking at the docs for :box, I only see the ability to set separate > vertical and horizontal widths (but not to set all 4 sides to different > values). The latter would be useful in some cases, for example to make > the tab-bar tabs look more like tabs. That is not the right way of displaying tabs with 3D appearance. We should provide professionally looking tabs, not some emulation of them with a box of 4 different width -- that would look extremely unprofessional and unclean. In general, I think the visual appearance of tab-bar and tab-line buttons needs a lot of love and care; what we have now simply looks badly, IMNSHO. We've basically copied the code that displays the tool bar, but without the attention that was at the time given to the visual appearance of the (native tool-bar buttons. The result is that the tool-bar buttons look much prettier than the tab bar and the tab lines. Compare our tab bar with that of any of the Web browsers out there, and you will see what I mean. there's no good reason why our tabs couldn't look as pretty as those of the browser, the only problem is that it involves coding in C, not Lisp. I still hope someone with experience in graphics programming will do that. > One benefit of making :color a cons cell is that it would be possible to > create an effect like `:style released-button', but allow the programmer > to control the exact colors to use. Once again, the released-button style should be produced by actually drawing a released button, like we do on the tool bar and the mode line. Playing color games with the :box attribute will produce an unclean emulation of that, and I therefore object to doing that. We shouldn't implement such unclean visuals.