From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5a8a5e3d: Input fontification for M-x shell Date: Fri, 09 Sep 2022 22:23:18 +0300 Message-ID: <83mtb8bbdl.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Miha Rihtarsic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 09 21:24:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWjcP-0004X5-2J for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Sep 2022 21:24:49 +0200 Original-Received: from localhost ([::1]:42934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWjcO-0007LH-5u for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Sep 2022 15:24:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWjb8-0006Tu-4s for emacs-devel@gnu.org; Fri, 09 Sep 2022 15:23:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWjb7-000793-Cj; Fri, 09 Sep 2022 15:23:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=CCoXV8Y/Pi3x/QdKqCRreq0GC1nZ72W5Fok+ZWmD6ks=; b=X9pwkE4yNBGobn EKmJhYQyYfunMhc9ognceAfnP2RnO9S4t/XP6YwcrSwhqwMRuzFzImGjSHCDEH01+z44WZnndUGnE X1rEIOCWiSeEw40ujUy01Pe8d1Nxo4HJgmByNmz6lB5ACozvgT51tDrBq9X48Y6nDCpE6SYuIUhh/ eC0fBrkwvMC6z9fvf46+wqy9HWgEFJQW0rL3pqbSwzUwdS+Y/jtFGl4rUPgxTTzRRsD/7ol6SvaIt b+os9tLZxpL6lbdI7aDEF9sEImjGurrlSlNz0W8he7EcDm2upC3jiyUfN9/a2TAUkxYTsKntt7E+U Em0BnzhdJ32sGDgD7kRQ==; Original-Received: from [87.69.77.57] (port=2608 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWjb6-0005K0-ML; Fri, 09 Sep 2022 15:23:29 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295092 Archived-At: > +(defcustom shell-indirect-setup-hook nil > + "Hook run after setting up an indirect shell fontification buffer." Thank you for working on these features. I have a general comment about this and other of your changes that were installed recently: It is not useful to have customizable user options whose doc string doesn't explain their purpose. It makes discovery and use of such options much harder. Imagine a user who upgrades to Emacs 29 and runs "M-x customize-changed" to learn about new options in the new version: what will such user understand by reading the doc string of this option? There's no explanation what are indirect shell fontification buffers, nor how and for what purpose they are used. Without that, it is impossible to understand when and how this hook could be useful. Could you please augment the doc string with the above in mind? The same goes for several other hooks in your changes installed today.