From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: rms@gnu.org, joaotavora@gmail.com, emacs-devel@gnu.org,
stephen_leake@stephe-leake.org
Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list
Date: Sat, 29 Oct 2022 10:24:30 +0300 [thread overview]
Message-ID: <83mt9fhz2p.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkW9vfR-GqGtjxuh6Dd92h-PJ45jAfZLeZ4MNSg3Vy0ow@mail.gmail.com> (message from Stefan Kangas on Fri, 28 Oct 2022 23:52:11 -0700)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 28 Oct 2022 23:52:11 -0700
> Cc: rms@gnu.org, joaotavora@gmail.com, emacs-devel@gnu.org,
> stephen_leake@stephe-leake.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > They also make patches harder to review, sometimes much harder.
>
> Fully agreed. That's why I'd prefer it if people would make whitespace
> changes separately from functional changes. Our current rule
> unfortunately seems to encourage putting it all in the same patch.
Having whitespace changes as part of code changes is inevitable, when
the changes modify indentation. You cannot separate them. We ask not
to make whitespace changes in places other than where the code is
being changed because that makes finding the "real" changes harder
than it has to be.
As for whitespace changes unrelated to code changes: we prefer not to
make them at all.
In any case, the suggestion to change our policy is a separate
discussion. My intent was to point out that we do have a policy, and
to make sure people who read this list are aware of that policy.
prev parent reply other threads:[~2022-10-29 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org>
[not found] ` <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org>
2022-10-25 9:29 ` master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list João Távora
2022-10-25 9:35 ` João Távora
2022-10-27 20:13 ` Richard Stallman
2022-10-28 5:42 ` Eli Zaretskii
2022-10-28 8:32 ` João Távora
2022-10-28 11:30 ` Eli Zaretskii
2022-10-28 19:45 ` Stefan Kangas
2022-10-29 5:56 ` Eli Zaretskii
2022-10-29 6:52 ` Stefan Kangas
2022-10-29 7:24 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt9fhz2p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=rms@gnu.org \
--cc=stefankangas@gmail.com \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).