From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Mon, 07 Aug 2023 17:47:02 +0300 Message-ID: <83msz2oqop.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <83h6pcrbe9.fsf@gnu.org> <11660747.27k8W16iEi@nimes> <87a5v45pmj.fsf@yahoo.com> <15527b3e-9334-c03d-e0a5-0828381a0071@cs.ucla.edu> <838raooy85.fsf@gnu.org> <875y5r4tfa.fsf@yahoo.com> <871qgf4qxs.fsf@yahoo.com> <83y1innlpe.fsf@gnu.org> <83v8drnjp5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 07 16:47:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qT1W5-0006aW-Ej for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Aug 2023 16:47:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qT1VR-0000Du-A7; Mon, 07 Aug 2023 10:46:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT1VO-0000DZ-OC for emacs-devel@gnu.org; Mon, 07 Aug 2023 10:46:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT1VL-00044G-Rp; Mon, 07 Aug 2023 10:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gLJ7D01C2LJYQpZV2fliGvyYsOOhZqIuyIZ6+4hYpSI=; b=hCciz/ZeET8g 5M45+eCJ8M3inPYpP2kcW1q/acZSZesktr9+MCzAi04mhwRkpMQpUQJIIumiHOisCLiZUOcUodvYi W/mE9PJjmMdA/W3JE38juVrtIK4iW3y8w9kElzxf4De2N7niic3VbYQxMtuGMBsmx60RwHR6ORdXr CccC3PufAHO16yNmzbtfz0pV3fHmZGuBQzWcX0bbgIkZjovrA0lYB237/NIE1qK8/ekAKwZK1JPmV HmOan6QRUCfx6puFCVEA4SlHeur9DUb34WUn18wcot2fU5BtVQrDV2fUnP/urLuANoNzn/OPL7ri2 sWUz6BbsX7UU0/MrR4CABw==; In-Reply-To: <83v8drnjp5.fsf@gnu.org> (message from Eli Zaretskii on Mon, 07 Aug 2023 15:03:18 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308414 Archived-At: > Date: Mon, 07 Aug 2023 15:03:18 +0300 > From: Eli Zaretskii > CC: eggert@cs.ucla.edu, emacs-devel@gnu.org > > Also, it looks like neither ENABLE_CHECKING nor GLYPH_DEBUG are being > defined in src/config.h in the non-Android builds, although I passed > the --enable-checking-'yes,glyphs' option to the configure script. > This has something to do with this snippet of configure.ac: No, it was because the Android test was incorrect. Now fixed. Btw, I don't think I understand the "test -n" part here: # There is little point in enabling checking in the build machine if # cross-compiling for Android. AS_IF([test "$with_android" = no || test -n "$XCONFIGURE"],[ if test x$ac_enable_checking != x ; then AC_DEFINE([ENABLE_CHECKING], [1], [Define to 1 if expensive run-time data type and consistency checks are enabled.]) fi It sounds like "test -n" there contradicts the comment: AFAIK non-zero length of $XCONFIGURE means we _are_ cross-compiling, and the comment says we don't want ENABLE_CHECKING in that case. Or maybe I don't understand the comment?