From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sat, 27 Feb 2010 16:54:50 +0200 Message-ID: <83ljeed8zp.fsf@gnu.org> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83pr3qddl4.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1267282514 16351 80.91.229.12 (27 Feb 2010 14:55:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2010 14:55:14 +0000 (UTC) Cc: lekktu@gmail.com, cyd@stupidchicken.com, emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 15:55:09 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlO4N-0008Ke-MB for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 15:55:03 +0100 Original-Received: from localhost ([127.0.0.1]:44126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlO4N-0001Z3-8K for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 09:55:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlO4I-0001Wj-80 for emacs-devel@gnu.org; Sat, 27 Feb 2010 09:54:58 -0500 Original-Received: from [140.186.70.92] (port=44720 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlO4H-0001VH-FX for emacs-devel@gnu.org; Sat, 27 Feb 2010 09:54:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlO4G-0000qR-Jf for emacs-devel@gnu.org; Sat, 27 Feb 2010 09:54:57 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:39309) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlO4G-0000qM-Aq for emacs-devel@gnu.org; Sat, 27 Feb 2010 09:54:56 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KYI00J008ZBQ900@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 27 Feb 2010 16:54:44 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.186.130]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYI00DQ39F7KPC0@a-mtaout20.012.net.il>; Sat, 27 Feb 2010 16:54:44 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121438 Archived-At: > From: Andreas Schwab > Cc: Juanma Barranquero , cyd@stupidchicken.com, emacs-devel@gnu.org > Date: Sat, 27 Feb 2010 15:31:30 +0100 > > Eli Zaretskii writes: > > > But then how come this defense in uniscribe_check_otf did not catch > > it? > > > > /* Check the spec is in the right format. */ > > if (!CONSP (otf_spec) || Flength (otf_spec) < 3) > > return 0; > > Because `Flength (otf_spec) < 3' is bogus. It should be `XINT (Flength > (otf_spec)) < 3'. Right you are.