unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: reveal-filename
Date: Tue, 21 May 2013 19:19:24 +0300	[thread overview]
Message-ID: <83li78uwz7.fsf@gnu.org> (raw)
In-Reply-To: <jwvd2sknc6r.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Tue, 21 May 2013 01:26:27 -0400
> 
> > The description that's already there is all there is to tell:
> >     "Produce the real file name for FILE.
> >   On systems other than MS-Windows, just returns FILE.
> >   On MS-Windows, converts /d/foo/bar form of file names
> >   passed by MSYS Make into d:/foo/bar that Emacs can grok.
> >   This function is called from lisp/Makefile."
> > What did you find missing from this description?
> 
> Looks very ad-hoc to me.

But that's what the function does, no less, no more.  And yes, it's
ad-hoc, because it simply works around an MSYS bug (I tried to find
other solutions, but failed).

> My guess is that the "cleaner" description that
> could correspond to it might be something along the lines of "accepts
> a file name in the format commonly used by other programs on the system,
> and turns it into an equivalent form that works within Emacs".

When the function is extended to do that, it would make sense to
change the doc string along these lines.  For now, saying that would
be simply incorrect.



  parent reply	other threads:[~2013-05-21 16:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 21:28 reveal-filename Stefan Monnier
2013-05-18  8:11 ` reveal-filename Eli Zaretskii
2013-05-21  2:02   ` reveal-filename Stefan Monnier
2013-05-21  2:52     ` reveal-filename Eli Zaretskii
2013-05-21  5:26       ` reveal-filename Stefan Monnier
2013-05-21  6:28         ` reveal-filename Stephen J. Turnbull
2013-05-21 16:22           ` reveal-filename Eli Zaretskii
2013-05-22  2:46             ` reveal-filename Stephen J. Turnbull
2013-05-21 16:19         ` Eli Zaretskii [this message]
2013-05-21 16:20         ` reveal-filename Eli Zaretskii
2013-05-21 19:37           ` reveal-filename Stefan Monnier
2013-05-25  7:21           ` reveal-filename Eli Zaretskii
2013-05-26  4:49             ` reveal-filename Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83li78uwz7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).