From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Fri, 24 Jan 2014 09:34:39 +0200 Message-ID: <83lhy5ests.fsf@gnu.org> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390548869 14903 80.91.229.3 (24 Jan 2014 07:34:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jan 2014 07:34:29 +0000 (UTC) Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 24 08:34:36 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6bHg-0003pr-8V for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 08:34:36 +0100 Original-Received: from localhost ([::1]:44808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6bHf-0000YM-Rs for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 02:34:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6bHY-0000WC-BF for emacs-devel@gnu.org; Fri, 24 Jan 2014 02:34:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6bHT-00062Y-7n for emacs-devel@gnu.org; Fri, 24 Jan 2014 02:34:28 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:51677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6bHS-00062S-VW for emacs-devel@gnu.org; Fri, 24 Jan 2014 02:34:23 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MZW008009RYEJ00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Fri, 24 Jan 2014 09:34:21 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZW0087OAD9E430@a-mtaout21.012.net.il>; Fri, 24 Jan 2014 09:34:21 +0200 (IST) In-reply-to: <52E18EC0.7090302@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168995 Archived-At: > Date: Thu, 23 Jan 2014 13:50:56 -0800 > From: Paul Eggert > Cc: Emacs developers > > For example, if we look at a recent simple patch (attached), it's > actually two changes, one change for each variable that was declared > on WINDOWSNT platforms but not used there. Alternatively, one could say in the log something like "Avoid compiler warnings due to unused variables." In any case, the comparison is invalid because this change wasn't fixing any bug, it's more like whitespace cleanup. > The situation for update-game-score was similar, and this is true of > many changes we make to Emacs. True or false, sumo changesets make maintenance harder, e.g., because they cannot be reverted easily.