From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Dynamic modules: should should-error work?
Date: Mon, 07 Dec 2015 22:18:34 +0200 [thread overview]
Message-ID: <83lh96c8rp.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQU+O_BxjFhTXswrek+7svOxX8371=qM56+3ZbXKjs6_A@mail.gmail.com>
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 07 Dec 2015 20:09:49 +0000
> Cc: emacs-devel@gnu.org
>
> > + (let ((descr (should-error (mod-test-sum 1 2 3))))
> > + (should (eq (car descr) 'wrong-number-of-arguments))
> >
> >
> > I think testing using :type would also accept subtypes of the given type,
> which
> > I think would be preferrable (I'd expect that generally subtypes of the
> > documented signals are allowed to be thrown).
>
> I'm not sure I understand what you are saying. Can you give an
> example?
>
> If it is documented that an error of type X is thrown, does that mean the error
> symbol is exactly X or rather that one of its conditions is X?
In general, the latter; but for wrong-number-of-arguments we know it
has no additional conditions, so it will be exactly it and nothing
else.
next prev parent reply other threads:[~2015-12-07 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 18:28 Dynamic modules: should should-error work? Eli Zaretskii
2015-11-23 19:28 ` Philipp Stephani
2015-11-23 20:09 ` Eli Zaretskii
2015-11-24 19:27 ` Philipp Stephani
2015-11-24 19:32 ` Eli Zaretskii
2015-12-07 20:09 ` Philipp Stephani
2015-12-07 20:18 ` Eli Zaretskii [this message]
2015-11-24 19:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lh96c8rp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).