From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Fri, 11 Dec 2015 18:20:02 +0200 Message-ID: <83lh916jpp.fsf@gnu.org> References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449850861 10708 80.91.229.3 (11 Dec 2015 16:21:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Dec 2015 16:21:01 +0000 (UTC) Cc: acm@muc.de, emacs-devel@gnu.org To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 11 17:20:49 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7QR6-0004JV-6y for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 17:20:48 +0100 Original-Received: from localhost ([::1]:48364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7QR5-0004cb-EL for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 11:20:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7QQx-0004cI-8q for emacs-devel@gnu.org; Fri, 11 Dec 2015 11:20:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7QQt-0001v6-Up for emacs-devel@gnu.org; Fri, 11 Dec 2015 11:20:39 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:49424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7QQt-0001tp-Nb for emacs-devel@gnu.org; Fri, 11 Dec 2015 11:20:35 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NZ700000BUIAI00@mtaout28.012.net.il> for emacs-devel@gnu.org; Fri, 11 Dec 2015 18:19:08 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NZ700NX1BZVS910@mtaout28.012.net.il>; Fri, 11 Dec 2015 18:19:08 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196123 Archived-At: > Date: Fri, 11 Dec 2015 16:00:27 +0000 > From: Artur Malabarba > Cc: Alan Mackenzie , emacs-devel > > 2015-12-11 12:39 GMT+00:00 Eli Zaretskii : > > For example, start with isearch-mode, and then try to figure out what > > each one of the following variables are in what use cases: > > regexp-function and search-default-regexp-mode (as a function). You > > will see that each one can be assigned to a variable that names a > > function that has a default value that can be a function that... > > I didn't reply to your initial message for lack of time. I can add > some comments here and there on the parts I understand. (some time in > the coming months) Thanks in advance. > > Similarly with other isearch commands. This makes the source > > impenetrable to uninitiated, much harder than just stepping with > > Edebug through the code. IMO, if it is easier to understand code by > > stepping through it in a debugger than by reading it, that code must > > be refactored or documented the heck of. > > Honestly, I'd love to overhaul isearch. But I couldn't do it > backwards-compatibly. That's what master is for.