From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions Date: Sun, 19 Jun 2016 19:55:14 +0300 Message-ID: <83lh2186fh.fsf@gnu.org> References: <83shwa9zmr.fsf@gnu.org> <83lh229ywc.fsf@gnu.org> <83inx69xcx.fsf@gnu.org> <0984ce22-cbcf-42a6-906e-a03b65f3c71c@default> <8360t5aolu.fsf@gnu.org> <83vb158awq.fsf@gnu.org> <83oa6x87ky.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466355371 19290 80.91.229.3 (19 Jun 2016 16:56:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jun 2016 16:56:11 +0000 (UTC) Cc: 23794@debbugs.gnu.org, rms@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org To: rswgnu@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 19 18:55:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bEg0o-0000Im-V6 for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2016 18:55:55 +0200 Original-Received: from localhost ([::1]:39436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEg0n-000116-Ru for ged-emacs-devel@m.gmane.org; Sun, 19 Jun 2016 12:55:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEg0h-00010o-Lo for emacs-devel@gnu.org; Sun, 19 Jun 2016 12:55:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEg0d-0007WR-F6 for emacs-devel@gnu.org; Sun, 19 Jun 2016 12:55:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEg0U-0007Vk-Js; Sun, 19 Jun 2016 12:55:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2744 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEg0K-0001zO-E5; Sun, 19 Jun 2016 12:55:25 -0400 In-reply-to: (message from Robert Weiner on Sun, 19 Jun 2016 12:51:08 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204532 Archived-At: > From: Robert Weiner > Date: Sun, 19 Jun 2016 12:51:08 -0400 > Cc: Drew Adams , Richard Stallman , > emacs-devel , 23794@debbugs.gnu.org > > On Sun, Jun 19, 2016 at 12:30 PM, Eli Zaretskii wrote: > > Didn't think that far, but is it really clean for sort-lines to have > special code for some major mode? I thought a better way is to > override the default behavior by having sort-lines call functions > through funcall or somesuch, and then outline modes could set the > appropriate variable to the function of their liking? > > The problem with that approach is that each mode has to be aware of this and add a setting, really not much > different than each mode having its own sort function or way of calling a sort function. It is much more useful > to centralize the behavior within the sorting library, even if it adds some conditional complexity to the code. Not necessarily: if you set that up in outline-mode, all of its descendants will inherit the setting for free. > Here is the suggested patch to do it this way. -- Bob Thanks, I hope others will comment on this.