From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Sun, 09 Jul 2017 17:22:37 +0300 Message-ID: <83lgnxk7v6.fsf@gnu.org> References: <83k23jl5ra.fsf@gnu.org> <87r2xqo8p7.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1499610209 22108 195.159.176.226 (9 Jul 2017 14:23:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Jul 2017 14:23:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 09 16:23:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUD7G-0005Ay-D3 for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 16:23:18 +0200 Original-Received: from localhost ([::1]:36350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUD7L-0002Sc-Ny for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 10:23:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUD6l-0002SU-JE for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:22:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUD6i-0000yE-Fb for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:22:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUD6i-0000y5-Bl; Sun, 09 Jul 2017 10:22:44 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3111 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dUD6h-0002fi-Qj; Sun, 09 Jul 2017 10:22:44 -0400 In-reply-to: <87r2xqo8p7.fsf@lylat> (message from Alex on Sat, 08 Jul 2017 16:38:44 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216367 Archived-At: > From: Alex > Cc: emacs-devel@gnu.org > Date: Sat, 08 Jul 2017 16:38:44 -0600 > > Why did you choose the name line-number-display-width over, e.g., > display-line-number-width? It seems every other related variable has a > prefix of display-. Not every other one: the faces start with line-number. Is the name that bad? It sounded right at the time, but if others think it might confuse, we could rename it. > P.S. I was thinking about how a minor mode for this should be > implemented. I attached a proof of concept, which includes a couple > extra variables to achieve line number width behaviour similar to > linum/nlinum. What do you think? Looks okay, although I'd drop the # part in the below: (add-hook 'pre-command-hook #'display-line-numbers-update-width nil t)) Thanks.