From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 885c512: Fix a bug in
	'generate-new-buffer-name'
Date: Sat, 05 Aug 2017 16:02:28 +0300
Message-ID: <83lgmyupzv.fsf@gnu.org>
References: <20170805095359.14455.50578@vcs0.savannah.gnu.org>
	<20170805095400.0316E20660@vcs0.savannah.gnu.org>
	<jwvmv7e41qm.fsf-monnier+emacsdiffs@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1501938170 13546 195.159.176.226 (5 Aug 2017 13:02:50 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sat, 5 Aug 2017 13:02:50 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 05 15:02:47 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ddyj2-000311-FL
	for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 15:02:40 +0200
Original-Received: from localhost ([::1]:56781 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ddyj8-0000cz-P1
	for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 09:02:46 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1ddyj1-0000cU-PM
	for emacs-devel@gnu.org; Sat, 05 Aug 2017 09:02:40 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1ddyiy-0001hy-KL
	for emacs-devel@gnu.org; Sat, 05 Aug 2017 09:02:39 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49352)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1ddyiy-0001hs-H4; Sat, 05 Aug 2017 09:02:36 -0400
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2356
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1ddyix-0000Y4-UQ; Sat, 05 Aug 2017 09:02:36 -0400
In-reply-to: <jwvmv7e41qm.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan
	Monnier on Sat, 05 Aug 2017 08:51:28 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:217314
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/217314>

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 05 Aug 2017 08:51:28 -0400
> 
> > -  if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name)))
> > +  if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore)))
> > +      || NILP (Fget_buffer (name)))
> 
> Why not just use Fequal instead of Fstring_equal?

Because no one said that using a symbol for the IGNORE argument is
forbidden in that function.  "nil" just happens to be a special case,
but other strings/symbols are allowed.