From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs-26 c87d04e: Avoid aborts in 'md5'
Date: Wed, 28 Feb 2018 17:52:07 +0200
Message-ID: <83lgfdyuvs.fsf@gnu.org>
References: <20180227164448.16622.42058@vcs0.savannah.gnu.org>
	<20180227164448.E4B45207B1@vcs0.savannah.gnu.org>
	<87h8q15xdo.fsf@gmx.de>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1519833054 18198 195.159.176.226 (28 Feb 2018 15:50:54 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 28 Feb 2018 15:50:54 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Michael Albinus <michael.albinus@gmx.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 16:50:49 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1er40G-0004QQ-9w
	for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 16:50:48 +0100
Original-Received: from localhost ([::1]:45261 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1er42I-0004rP-UY
	for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 10:52:54 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1er41U-0004pm-Bl
	for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:52:05 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1er41P-0002HZ-Hc
	for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:52:04 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59527)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1er41P-0002HR-D8; Wed, 28 Feb 2018 10:51:59 -0500
Original-Received: from [176.228.60.248] (port=3437 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1er41O-0002S6-Rw; Wed, 28 Feb 2018 10:51:59 -0500
In-reply-to: <87h8q15xdo.fsf@gmx.de> (message from Michael Albinus on Wed, 28
	Feb 2018 09:30:59 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:223171
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/223171>

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 28 Feb 2018 09:30:59 +0100
> 
> > +  if (!STRINGP (object))
> > +    signal_error ("Invalid object argument",
> > +		  NILP (object) ? build_string ("nil") : object);
> >    return SSDATA (object);
> >  }
> 
> Don't we call CHECK_STRING (object) in such cases, which raises the
> standardized error Qwrong_type_argument?

Using CHECK_STRING would produce a misleading error message, because
the APIs that call extract_data_from_object accept objects other than
strings.