From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Wed, 05 Sep 2018 18:21:00 +0300 Message-ID: <83lg8gx95v.fsf@gnu.org> References: <83tvn5xicp.fsf@gnu.org> <86lg8hf3dy.fsf@gmail.com> <8c20c37f-983b-08e6-177f-9223f33914fc@cs.ucla.edu> <87ftyorixx.fsf@tromey.com> <8636uo954f.fsf@gmail.com> <0ef8eb60-39dc-39cf-12f9-91240f876729@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536160756 32364 195.159.176.226 (5 Sep 2018 15:19:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 15:19:16 +0000 (UTC) Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 17:19:11 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxZaD-00084W-B6 for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 17:19:05 +0200 Original-Received: from localhost ([::1]:56753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZcJ-0000hk-D3 for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 11:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZcC-0000h9-MJ for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:21:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxZc9-0001Ww-HC for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:21:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZc9-0001WI-CV; Wed, 05 Sep 2018 11:21:05 -0400 Original-Received: from [176.228.60.248] (port=1412 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxZc8-0001rx-8C; Wed, 05 Sep 2018 11:21:04 -0400 In-reply-to: <0ef8eb60-39dc-39cf-12f9-91240f876729@cs.ucla.edu> (message from Paul Eggert on Tue, 4 Sep 2018 17:56:03 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229296 Archived-At: > From: Paul Eggert > Date: Tue, 4 Sep 2018 17:56:03 -0700 > > Andy Moreton wrote: > > Dumping of bignums is not currently required by any emacs code, but it > > should be supported unless there is some unreasonable difficulty in > > doing so. > > The difficulty seems to be that memory allocation doesn't work for it, at least > on MS-Windows. Fixing this is low priority, admittedly. I don't think there's anything that needs to be fixed here. Dumping pure bignums should not cause any trouble any more than dumping pure strings. The only issue is that mp_set_memory_functions must be called before we call any GMP functions that might allocate memory.