From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Towards a cleaner build: arc-mode
Date: Sat, 18 May 2019 08:39:32 +0300
Message-ID: <83lfz49v8r.fsf@gnu.org>
References: <m3r28xrfl9.fsf@gnus.org> <m3a7flgygs.fsf@gnus.org>
	<83d0khb888.fsf@gnu.org> <m3woioct63.fsf@gnus.org>
	<m3sgtccsry.fsf@gnus.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="18101"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 07:40:13 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hRs4q-0004Xl-Nn
	for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 07:40:12 +0200
Original-Received: from localhost ([127.0.0.1]:57970 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hRs4p-0007vV-LJ
	for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 01:40:11 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:40855)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hRs4G-0007vC-Rq
	for emacs-devel@gnu.org; Sat, 18 May 2019 01:39:37 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41914)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hRs4G-00079x-Oy; Sat, 18 May 2019 01:39:36 -0400
Original-Received: from [176.228.60.248] (port=3099 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hRs4G-0002J4-9M; Sat, 18 May 2019 01:39:36 -0400
In-reply-to: <m3sgtccsry.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 
	18 May 2019 06:04:33 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236698
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236698>

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 18 May 2019 06:04:33 +0200
> 
> >> We have get-byte nowadays, so I believe the first defsubst is not
> >> needed.  You just need to catch errors, maybe.
> 
> For byte-after, I tried this:
> 
> (defun byte-after (pos)
>   "Like char-after but an eight-bit char is converted to unibyte."
>   (cl-assert (= (multibyte-char-to-unibyte (char-after pos))
>                 (get-byte pos)))
>   (get-byte pos))
> 
> I then opened some archives (which will use byte-after all over the
> place), and I got no assertion errors.
> 
> If you think it's OK, I can just replace all the calls to byte-after
> with get-byte in arc-mode.el and remove the defsubst. 

Yes, I think that would be fine, thanks.