From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Wed, 02 Oct 2019 18:06:36 +0300 Message-ID: <83lfu389vn.fsf@gnu.org> References: <834l4xbfmp.fsf@gnu.org> <87ef414dfn.fsf@wavexx.thregr.org> <83o9359w3l.fsf@gnu.org> <83eezycce5.fsf@gnu.org> <87muekj0i9.fsf@wavexx.thregr.org> <87d0fgagjl.fsf@gnus.org> <20191001225254.mwjnxlynjdc3mz7y@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60253"; mail-complaints-to="usenet@blaine.gmane.org" Cc: wavexx@thregr.org, spacibba@aol.com, larsi@gnus.org, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 17:09:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFgFf-000FX2-13 for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 17:09:15 +0200 Original-Received: from localhost ([::1]:56360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFgFd-0002RJ-A8 for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 11:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45928) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFgDP-0008DH-AY for emacs-devel@gnu.org; Wed, 02 Oct 2019 11:06:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFgDO-0002ZB-Dw; Wed, 02 Oct 2019 11:06:54 -0400 Original-Received: from [176.228.60.248] (port=1641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFgDN-00074h-Qc; Wed, 02 Oct 2019 11:06:54 -0400 In-reply-to: (message from Juanma Barranquero on Wed, 2 Oct 2019 01:51:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240472 Archived-At: > From: Juanma Barranquero > Date: Wed, 2 Oct 2019 01:51:17 +0200 > Cc: Lars Ingebrigtsen , "Yuri D'Elia" , Eli Zaretskii , > Emacs developers > > > 1) I don't have any strong feeling about using one or two values. But in > > any case they should be configurable. This will add more use cases that > > could benefit with this and I think it will be simple to implement (just > > need to add 2 int variables). > > Adding the variables is trivial, yes. The problem is dealing with errors, like the user setting the variables to > non-numbers, etc. I'm sure we don't want to throw signals there, do we? > > Eli, opinions? You cannot usefully signal an error from redisplay. So if the values don't match expectations, use the hard-coded defaults instead. If this is documented ("Any other value is treated as ..."), we are fine.