From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Merging the underline attribute at EOL
Date: Mon, 23 Dec 2019 15:35:26 +0200
Message-ID: <83lfr3xizl.fsf@gnu.org>
References: <83eex771ky.fsf@gnu.org> <20191216161104.767sfxj7taabs5jl@Ergus>
 <83v9qg42vz.fsf@gnu.org> <20191216203156.oojz2o3uskxsgd5a@Ergus>
 <83lfrb4owb.fsf@gnu.org> <20191217141345.z3ldbj4nolrgmbqo@Ergus>
 <834kxy50rk.fsf@gnu.org> <20191219011910.bhvwrcco56uv2znm@Ergus>
 <83woas1g1g.fsf@gnu.org> <20191222224639.rbeslrfnivhenciv@Ergus>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="104705"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Ergus <spacibba@aol.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 23 14:35:50 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ijNsE-000R5V-Ew
	for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 14:35:50 +0100
Original-Received: from localhost ([::1]:57018 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1ijNsD-0001QV-8a
	for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 08:35:49 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51537)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1ijNs8-0001QM-6d
 for emacs-devel@gnu.org; Mon, 23 Dec 2019 08:35:45 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56048)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1ijNs8-00082I-3P; Mon, 23 Dec 2019 08:35:44 -0500
Original-Received: from [176.228.60.248] (port=4853 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1ijNs7-0000PS-FT; Mon, 23 Dec 2019 08:35:43 -0500
In-reply-to: <20191222224639.rbeslrfnivhenciv@Ergus> (message from Ergus on
 Sun, 22 Dec 2019 23:46:39 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:243581
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/243581>

> Date: Sun, 22 Dec 2019 23:46:39 +0100
> From: Ergus <spacibba@aol.com>
> Cc: emacs-devel@gnu.org
> 
> Sorry for the big latency in my replies. Busy days.

(Btw, messages to you frequently bounce.)

> >But if the default face has underline or overline or box etc.,
> >attributes, we don't want to exit early, even though its background
> >color is the default, right?
> >
> Then the simpler solution is the attached patch I have been using for
> some days... It just extends the conditions in the if (as you suggested
> since the beginning).
> 
> If it is fine for you, then you can commit the patch for me.

Done, thanks.