unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: emacs-27 f61bff3: ; * CONTRIBUTE: Clarify the preferences for patch formatting.
       [not found] ` <20200620084339.ADFD620A27@vcs0.savannah.gnu.org>
@ 2020-07-20 16:29   ` Robert Pluim
  2020-07-20 18:34     ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2020-07-20 16:29 UTC (permalink / raw)
  To: emacs-devel; +Cc: Eli Zaretskii

>>>>> On Sat, 20 Jun 2020 04:43:39 -0400 (EDT), eliz@gnu.org (Eli Zaretskii) said:
    Eli> +  git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch'.
    Eli> +
    Eli> +However, we prefer the 'git format-patch' method with attachment, as
    Eli> +doing so delivers patches in the correct and easily-recognizable format
    Eli> +more reliably, and makes the job of applying the patches easier and less
    Eli> +error-prone.  It also allows to send patches whose author is someone
    Eli> +other than the email sender.

'sending', but thatʼs minor. Do we want to mention
'disposition=inline' here, or is that too much? (I donʼt really mind
since Gnus can be told to show specific attachments inline anyway, but
maybe other MUAs can't)

Robert



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-27 f61bff3: ; * CONTRIBUTE: Clarify the preferences for patch formatting.
  2020-07-20 16:29   ` emacs-27 f61bff3: ; * CONTRIBUTE: Clarify the preferences for patch formatting Robert Pluim
@ 2020-07-20 18:34     ` Eli Zaretskii
  2020-07-21  8:00       ` Robert Pluim
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2020-07-20 18:34 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 20 Jul 2020 18:29:47 +0200
> 
>     Eli> +error-prone.  It also allows to send patches whose author is someone
>     Eli> +other than the email sender.
> 
> 'sending', but thatʼs minor.

Feel free to fix.

> Do we want to mention 'disposition=inline' here, or is that too
> much?

No, I actually prefer an attachment.  It's safer, IME.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-27 f61bff3: ; * CONTRIBUTE: Clarify the preferences for patch formatting.
  2020-07-20 18:34     ` Eli Zaretskii
@ 2020-07-21  8:00       ` Robert Pluim
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2020-07-21  8:00 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

>>>>> On Mon, 20 Jul 2020 21:34:26 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Eli Zaretskii <eliz@gnu.org>
    >> Date: Mon, 20 Jul 2020 18:29:47 +0200
    >> 
    Eli> +error-prone.  It also allows to send patches whose author is someone
    Eli> +other than the email sender.
    >> 
    >> 'sending', but thatʼs minor.

    Eli> Feel free to fix.

Done

    >> Do we want to mention 'disposition=inline' here, or is that too
    >> much?

    Eli> No, I actually prefer an attachment.  It's safer, IME.

OK. I guess I should stop setting 'inline' on the patches I send to
emacs-devel, then.

Robert



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-21  8:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20200620084338.11093.79578@vcs0.savannah.gnu.org>
     [not found] ` <20200620084339.ADFD620A27@vcs0.savannah.gnu.org>
2020-07-20 16:29   ` emacs-27 f61bff3: ; * CONTRIBUTE: Clarify the preferences for patch formatting Robert Pluim
2020-07-20 18:34     ` Eli Zaretskii
2020-07-21  8:00       ` Robert Pluim

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).