From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 22:21:31 +0200 Message-ID: <83lfe859ro.fsf@gnu.org> References: <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <837dpt8lk5.fsf@gnu.org> <87pn3kjssr.fsf@gnus.org> <83im9c70vu.fsf@gnu.org> <87im9cfeej.fsf@gnus.org> <837dps6xyv.fsf@gnu.org> <87czzkdx57.fsf@gnus.org> <83v9dc5he3.fsf@gnu.org> <87r1o0chk9.fsf@gnus.org> <83tusw5g5o.fsf@gnu.org> <87360gaz7o.fsf@gnus.org> <87y2i89jjk.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 22:40:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmkie-0003ot-Hm for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 22:40:24 +0100 Original-Received: from localhost ([::1]:54044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmkid-0000w7-FO for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 16:40:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmjUV-0004Qo-WF for emacs-devel@gnu.org; Tue, 08 Dec 2020 15:21:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58545) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmjUS-00037d-Qm; Tue, 08 Dec 2020 15:21:40 -0500 Original-Received: from [176.228.60.248] (port=3834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmjUQ-0002vP-VL; Tue, 08 Dec 2020 15:21:39 -0500 In-Reply-To: <87y2i89jjk.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 08 Dec 2020 20:36:47 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260583 Archived-At: > From: Lars Ingebrigtsen > Cc: ghe@sdf.org, Eli Zaretskii , emacs-devel@gnu.org > Date: Tue, 08 Dec 2020 20:36:47 +0100 > > + case Lisp_String: > + val = (EMACS_UINT) SSDATA (obj); Why use the pointer? Lisp strings can be relocated, and there could be another string with the same contents. Why not support those? > @@ -1649,7 +1650,7 @@ uncache_image (struct frame *f, Lisp_Object spec) > can have multiple copies of an image with the same spec. We want > to remove them all to ensure the user doesn't see an old version > of the image when the face changes. */ > - while ((img = search_image_cache (f, spec, sxhash (spec), 0, 0, true))) > + while ((img = search_image_cache (f, spec, img_hash (spec), 0, 0, true))) Any reason you call img_hash in a loop with the same argument? Last, but not least, a question: what kind of savings will this produce, and why? Thanks.