From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Git master head build failure? Date: Thu, 01 Apr 2021 10:33:20 +0300 Message-ID: <83lfa2h327.fsf@gnu.org> References: <875z16en2o.fsf@gmail.com> <8735waelo4.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38250"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Tim Cross Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 01 09:34:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRrqa-0009pn-8a for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 09:34:32 +0200 Original-Received: from localhost ([::1]:52922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRrqZ-0001vN-B4 for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 03:34:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRrpm-0001Ur-7E for emacs-devel@gnu.org; Thu, 01 Apr 2021 03:33:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49534) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRrpl-0007lJ-Ik; Thu, 01 Apr 2021 03:33:41 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1911 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lRrpg-0002pW-82; Thu, 01 Apr 2021 03:33:41 -0400 In-Reply-To: <8735waelo4.fsf@gmail.com> (message from Tim Cross on Thu, 01 Apr 2021 14:10:50 +1100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267240 Archived-At: > From: Tim Cross > Date: Thu, 01 Apr 2021 14:10:50 +1100 > Cc: emacs-devel@gnu.org > > I wonder if it would be possible for make maintainer-clean to somehow > look at what is in .gitignore and ensure anything in there is also > removed? Would be good if at least that target returned the repo to an > exact replica of what you would get if you did a fresh clone. First, you should be using extraclean, not maintainer-clean; see the top-level Makefile.in for the documentation of the various clean targets. And second, we should simply make sure extraclean removes all the generated files, as documented, and keep it that way. Looking into .gitignore means either building its interpreter into our build system (a non-trivial job, AFAIU), or using Git itself to do the job, which would mean the job cannot be done without Git -- a disadvantage, IMO.