From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with
 dos encoding
Date: Mon, 16 Aug 2021 15:29:16 +0300
Message-ID: <83lf518ter.fsf@gnu.org>
References: <CA+G3_PPNdCS8QWtemUuZ1LgwcwaLc=YLnSokcU9u9zc=OG+U7A@mail.gmail.com>
 <87o89ygyu8.fsf@gnus.org>
 <CA+G3_PORBJ9RcBmNBpix-d2b_B-FRVgohmawyOjMfDFmxN7VQw@mail.gmail.com>
 <87bl5xfvjv.fsf@gnus.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="22436"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: tgbugs@gmail.com, emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 14:29:55 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mFbkZ-0005TJ-9y
	for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 14:29:55 +0200
Original-Received: from localhost ([::1]:60016 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mFbkY-0007Fw-9B
	for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 08:29:54 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35640)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mFbk3-0006ZN-SW
 for emacs-devel@gnu.org; Mon, 16 Aug 2021 08:29:23 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46380)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mFbk3-0007eg-Jd; Mon, 16 Aug 2021 08:29:23 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4718
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mFbk3-0004w6-6J; Mon, 16 Aug 2021 08:29:23 -0400
In-Reply-To: <87bl5xfvjv.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 
 16 Aug 2021 14:01:08 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:272432
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/272432>

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 16 Aug 2021 14:01:08 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> So I think your revised patch is correct -- the `subst-char-in-region'
> thing is just plain wrong and should be removed.

You only considered the case of DOS EOL format.  What about the Mac
EOL format?

More importantly, what about selective-display, which replaces
newlines with \r's?  I think this replacement is for that use case.

So perhaps the condition for the replacement should be
selective-display?