From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug-reference-prog-mode slows down CC Mode's scrolling by ~7% Date: Wed, 01 Sep 2021 21:28:49 +0300 Message-ID: <83lf4gp2u6.fsf@gnu.org> References: <83r1e8p4w8.fsf@gnu.org> <83mtowp430.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 01 20:29:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLUzJ-0009eH-IB for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Sep 2021 20:29:29 +0200 Original-Received: from localhost ([::1]:51518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLUzH-0006Wf-4R for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Sep 2021 14:29:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLUyk-0005qd-RQ for emacs-devel@gnu.org; Wed, 01 Sep 2021 14:28:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60762) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLUyk-00027u-6k; Wed, 01 Sep 2021 14:28:54 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4854 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLUyj-0005M0-NM; Wed, 01 Sep 2021 14:28:54 -0400 In-Reply-To: (message from Alan Mackenzie on Wed, 1 Sep 2021 18:20:25 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273681 Archived-At: > Date: Wed, 1 Sep 2021 18:20:25 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > > Then I think the easiest fix is to get bug-reference-prog-mode return > > a suitable value, or wrap it in a function that would. Every function > > that puts itself on jit-lock-functions without actually fontifying > > anything should return BOB..EOB as the region it fontified, right? > > I'm not sure that's the right fix. If font-lock mode were disabled, say, > bug-reference-fontify would be the only function on jit-lock-functions. But that never happens, does it? Or if we want to be holier than the Pope, bug-reference-fontify could check if it's the only function on the list, and then change its return value accordingly. > The mechanism with `jit-lock-bounds' in jit-lock.el is a good idea, but > somehow it's not quite optimal at the moment. It was designed for functions that actually fontify something. We need to either extend it for functions that don't, or change those functions to pretend they do, but in a way that doesn't disrupt jit-lock-bounds. > For example, if the first jit-lock-functions element returns > (... (new-BEG . new-END)) we might be able to supply new-BEG, new-END as > the arguments to the second element. Or something like that. I think it's too late to change the protocol, since it was in use for too long.