From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Fri, 10 Dec 2021 16:26:27 +0200 Message-ID: <83lf0ssfho.fsf@gnu.org> References: <83k0geuoi1.fsf@gnu.org> <87czm6ax3c.fsf@yahoo.com> <838rwuukkx.fsf@gnu.org> <878rwuavr7.fsf@yahoo.com> <831r2mug6n.fsf@gnu.org> <83zgpat0di.fsf@gnu.org> <87v8zy9c4o.fsf@yahoo.com> <87r1am9bsz.fsf@yahoo.com> <83wnkesz7r.fsf@gnu.org> <87mtl9apcx.fsf@yahoo.com> <83v8zxucaz.fsf@gnu.org> <87ilvxao13.fsf@yahoo.com> <83r1alub0m.fsf@gnu.org> <83pmq5ua9p.fsf@gnu.org> <83o85pu9u0.fsf@gnu.org> <83mtl9u9c8.fsf@gnu.org> <87a6h99uk5.fsf@yahoo.com> <875yrx9tlo.fsf@yahoo.com> <831r2kua9o.fsf@gnu.org> <877dcc6bw7.fsf@yahoo.com> <87wnkc4lrj.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 10 15:29:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvgtu-0004D6-IZ for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 15:29:30 +0100 Original-Received: from localhost ([::1]:53508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvgtt-0001Cp-EJ for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 09:29:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgrC-0007iZ-4d for emacs-devel@gnu.org; Fri, 10 Dec 2021 09:26:42 -0500 Original-Received: from [2001:470:142:3::e] (port=53952 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgrB-0007gA-Pu; Fri, 10 Dec 2021 09:26:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XLKGIA6ioev6xn2dejIlTiEpp8G8ENYEHFAu4fGXEVQ=; b=bdhiAX0OhFJi BnPxGbgjSq2hhVKryART+8oVAvZ/jwkXsOiMxE9iv3cTnH/MpaFDpouAk6y9MXuUmDm+IXhvV20cF dc1/g1+VIEfOTBb/VV6zTHLvKIjrvP+xdWgjDQbk4ITLDgxZUyhabuLnjGwrUYP6vtiirJcDMaMw8 XvvzvqlTf9QZXpo2sMXkF+VhI6xKTbQp5haQsoENhaoEADHyReZiMYCok6CH30pebsnyt///KBh8D PCY65Y7rPKRCPSdm7vXkvGGWxb8YQ58n0yc+ZH/ouBZRhvmM+BXKL1n0XsL59Tl1rP2sq59PI2NGi SDOosRWAyF6OtrYOYcxlAg==; Original-Received: from [87.69.77.57] (port=4460 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgrA-0004cu-ME; Fri, 10 Dec 2021 09:26:40 -0500 In-Reply-To: <87wnkc4lrj.fsf@yahoo.com> (message from Po Lu on Fri, 10 Dec 2021 21:44:48 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281599 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Fri, 10 Dec 2021 21:44:48 +0800 > > I got the MS-DOS port to work. Everything seems to run normally, but > someone might need to run it under a DOS machine (as opposed to the > NTVDM) to be sure. That someone isn't myself, as I don't have a DOS machine. How did you test the build? What commands did you try? My "standard minimum" set of tests for the DOS port is: . Visit a couple of files in different major modes and make sure there're no error messages . Type "C-x" and verify that the "C-x-" prompt appears after a second of delay . Type "M-x display-time-mode RET" and verify that Emacs displays time correctly, updating it every minute . Click on the menu bar and verify that menus work and display with correct colors . Move the mouse over the mode line and verify that it is mouse-sensitive, and help-echo is displayed in the echo-area . "C-h i" and verify that the help-echo for the menu items works when you move the mouse above them, mouse clicks on the header line work, and non-ASCII characters in the manual are correctly replaced with their ASCII equivalents . "M-x compile" to compile some simple C program with a syntax error, and verify that the *Compilation* buffer pops up with the error message(s), the exit code is correctly reported, and clicking on the message displays the offending source line . "M-x customize-variable", select some variable, and verify that the drop-down menus in the Custom buffer work . C-z, verify that you are dropped to a subordinate shell, invoke some shell command, then type "exit RET" to verify that you are back in Emacs > If you have no further comments (and it doesn't break the build on > non-DOS platforms), I would like to install the following change on the > Emacs 28 branch (and hopefully get it to work on master as well: the DOS > port will probably not work there either): Thanks, see the comments below. > --- a/msdos/sed1v2.inp > +++ b/msdos/sed1v2.inp > @@ -55,6 +55,10 @@ s/ *@LIBJPEG@// > s/ *@LIBPNG@// > s/ *@LIBGIF@// > s/ *@LIBXPM@// > +/^HAVE_NATIVE_COMP *=/s/@HAVE_NATIVE_COMP@// > +/^HAVE_PDUMPER *=/s/@HAVE_PDUMPER@// These two should be replaced with "no", not with empty values, I think. > +/^JSON_CFLAGS *=/s/@JSOB_CFLAGS@// > +/^JSON_LIBS *=/s/@JSOB_LIBS@// Typos: should be JSON_CFLAGS and JSON_LIBS. > +/^JSON_CFLAGS *=/s/@JSON_CFLAGS@// > +/^JSON_LIBS *=/s/@JSON_LIBS@// > +/^JSON_CFLAGS *=/s/@JSON_CFLAGS@// > +/^JSON_LIBS *=/s/@JSON_LIBS@// These should be redundant once you fix the typos above. > +OMIT_GNULIB_MODULE_crypto\/md5 = true Don't we need md5? Why are you omitting it? > +ifneq ($(MSDOS_OBJ),) > +temacs$(EXEEXT): $(LIBXMENU) $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(EMACSRES) \ > + $(charsets) $(charscript) ${emoji-zwj} $(MAKE_PDUMPER_FINGERPRINT) > + $(AM_V_CCLD)$(CC) -o $@ \ > + $(ALL_CFLAGS) $(TEMACS_LDFLAGS) $(LDFLAGS) \ > + $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(W32_RES_LINK) $(LIBES) > + $(MKDIR_P) $(etc) > +else > ## We have to create $(etc) here because init_cmdargs tests its > ## existence when setting Vinstallation_directory (FIXME?). > ## This goes on to affect various things, and the emacs binary fails Couldn't you use the original recipe by a trivial editing (it seems all you need is to replace $@.tmp with $@?), instead of adding an ifdef? Come to think of that, why not use the original recipe without any changes, as it moves $@.tmp to $@ after the link succeeds? > +int > +fchmodat (int fd, const char *path, mode_t mode, int flags) > +{ > + if (fd != AT_FDCWD) > + { > + if (strlen (dir_pathname) + strlen (path) + 1 >= MAXPATHLEN) > + { > + errno = ENAMETOOLONG; > + return -1; > + } > + } > + > + return 0; > +} This returns zero without doing anything, why? I think it should call chmod when fd == AT_FDCWD. > +int > +futimens (int fd, const struct timespec times[2]) > +{ > + /* TODO */ > + return 0; > +} > + > +int > +utimensat (int dirfd, const char *pathname, > + const struct timespec times[2], int flags) > +{ > + /* TODO */ > + return 0; > +} What about these TODOs? Thanks a lot for working on this.