From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Fri, 04 Feb 2022 14:06:39 +0200 Message-ID: <83leyq3kfk.fsf@gnu.org> References: <058b682b11240176288f@heytings.org> <83h79tjd2f.fsf@gnu.org> <058b682b11f58780b580@heytings.org> <83v8y8ij39.fsf@gnu.org> <6a5bb5a08b3d764611f9@heytings.org> <6a5bb5a08b6337d733c5@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, mattiase@acm.org, gregory@heytings.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 04 13:07:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFxNa-0005r4-26 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 13:07:54 +0100 Original-Received: from localhost ([::1]:53792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFxNY-0005JM-F1 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 07:07:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFxMI-0004aB-Fc for emacs-devel@gnu.org; Fri, 04 Feb 2022 07:06:34 -0500 Original-Received: from [2001:470:142:3::e] (port=32990 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFxMH-0006p9-GK; Fri, 04 Feb 2022 07:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AvblA1JmqPr1K456f5mch/XfcBRakyG/83NFt6PrO6Y=; b=NYSGBykXqGkS mM3RxkiO2q1z7QFNsjUQvejEkKeH8DQ4h4V2SYl6rhGXWUW6bdPjPuHwZ45IJBEaFAKvepmiNtxLx bx/sYA9hLjiskAjIZLz4vjrNT8mDuct7ZAFBDK5djf2W6VN/wKyta7Q6AZc+J9Rdykt6UTaz5B0rl MV3gtjQeoRLKOce0Q78d+7HOFwZ1u/d04uSeGFw41V6S9BC7bcvbONmRCele1f1a9rkUvAPxBkKDq 7iji6wkZz3cEiH7/YMlcIv2tZLknEPViMZMnPG6eUL4WrPmueB0iIlHlEEhu4X5zVAYmW+ywLtX/e 9Y1jN68Cvx+RK/DTV1nMcQ==; Original-Received: from [87.69.77.57] (port=3705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFxMG-00046T-Uj; Fri, 04 Feb 2022 07:06:33 -0500 In-Reply-To: (message from Alan Mackenzie on Fri, 4 Feb 2022 11:57:21 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285861 Archived-At: > Date: Fri, 4 Feb 2022 11:57:21 +0000 > Cc: Stefan Monnier , mattiase@acm.org, > Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org > From: Alan Mackenzie > > Compilation _does_ do things differently. It runs with > symbols-with-pos-enabled bound to t, which makes EQ slower than when > that variable is nil. To see this, have a look at the defition of > lisp_h_EQ in src/lisp.h, around line 372. Can you explain why we need to complicate EQ so much to account for symbols-with-pos? Specific questions: . comparison of a symbol and symbol-with-pos should only compare the symbol part, and disregard the "pos" part, right? . if so, couldn't we implement symbol-with-pos as a struct that has the symbol at its beginning, and then use memcmp to compare only that part? Or what am I missing?