From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix placement of toggle and radio button in Lucid menu.
Date: Sat, 26 Feb 2022 10:53:20 +0200 [thread overview]
Message-ID: <83lexyovpb.fsf@gnu.org> (raw)
In-Reply-To: <87mtie3tzs.fsf@yahoo.com> (message from Po Lu on Sat, 26 Feb 2022 16:35:51 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org
> Date: Sat, 26 Feb 2022 16:35:51 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > That's not the impression I get when I look at the definition of
> > MENU_FONT_HEIGHT in xlwmenu.c: it does use the font attributes used by
> > the "usual" font backends, at least in the case of XFT and Cairo. Am
> > I missing something?
>
> They are the same attributes, but I think they're computed differently.
>
> AFAIK the font backends calculate ascent and descent on a per-glyph
> basis, while the Lucid menu bar widget uses the maximum ascent and
> descent values for the entire font.
Are you sure? We have the font's "global" ascent, descent, and height
values in the font backends as well. See, for example, ftfont.c
around line 1390.
We do also use per-character glyph metrics as well, in
gui_produce_glyphs, which is why I suggested to compare those for the
font used in the Lucid menus. But we use the font's global values as
fallback.
next prev parent reply other threads:[~2022-02-26 8:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 9:01 [PATCH] Fix placement of toggle and radio button in Lucid menu Manuel Giraud
2022-02-24 10:06 ` Po Lu
2022-02-24 10:19 ` Po Lu
2022-02-24 10:36 ` Eli Zaretskii
2022-02-24 14:09 ` Manuel Giraud
2022-02-25 11:16 ` Manuel Giraud
2022-02-25 11:50 ` Po Lu
2022-02-26 17:38 ` Manuel Giraud
2022-02-25 12:18 ` Eli Zaretskii
2022-02-25 12:52 ` Manuel Giraud
2022-02-25 13:05 ` Eli Zaretskii
2022-02-25 13:46 ` Po Lu
2022-02-25 14:10 ` Eli Zaretskii
2022-02-26 0:20 ` Po Lu
2022-02-26 6:24 ` Eli Zaretskii
2022-02-26 7:33 ` Po Lu
2022-02-26 7:51 ` Eli Zaretskii
2022-02-26 8:35 ` Po Lu
2022-02-26 8:53 ` Eli Zaretskii [this message]
2022-02-25 14:46 ` Manuel Giraud
2022-02-25 14:57 ` Eli Zaretskii
2022-02-25 15:38 ` Manuel Giraud
2022-02-25 16:35 ` Eli Zaretskii
2022-02-26 0:21 ` Po Lu
2022-02-26 6:26 ` Eli Zaretskii
2022-02-26 7:35 ` Po Lu
2022-02-28 8:45 ` Manuel Giraud
2022-02-28 13:21 ` Eli Zaretskii
2022-02-28 21:19 ` Manuel Giraud
2022-03-01 3:33 ` Eli Zaretskii
2022-03-02 12:06 ` Manuel Giraud
2022-02-28 18:35 ` chad
2022-03-02 12:10 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lexyovpb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).