From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Fri, 04 Mar 2022 09:14:34 +0200 Message-ID: <83lexqi3z9.fsf@gnu.org> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 08:17:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ2CC-0004QT-Kx for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 08:17:48 +0100 Original-Received: from localhost ([::1]:55766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ2CB-0002to-C9 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 02:17:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ295-0000NN-4W for emacs-devel@gnu.org; Fri, 04 Mar 2022 02:14:35 -0500 Original-Received: from [2001:470:142:3::e] (port=41134 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ294-0001EQ-Aw; Fri, 04 Mar 2022 02:14:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MnMF1rDCKllsznZO2B5wUUzynxiA1aNhRBK1sbrbwNI=; b=Zj25MUiYKhuT m4bqRtHnzO7aBIGKQ/fduR81uxTovqGuMWw71/mnwrh/zaoHV7Bd8BXG6d5udtZMCdJdmtR5WwrBA xcrDbcQ12gSDHAsDaVygdnh5XQTFOJY/hzid5Cl8Nvfis5no38eM1fYrtRt5PjM4rvDRiw2H2e28s SQrouYpYqfIp0AoBb2Z9INblW4fOS6znjMyeNqteD7rV9Am5+zo8JHZD2e0HnOkZp0L7/FfqNkLW1 26PGR1qnQJRmjCoa5Wah2DZc64EwtsI9GHzPCX5aGatC3WPRGlDfmE6H+j9c/S+nU0W/uUcvia+2e 6XMchkWWJh2RCdCliIPhlg==; Original-Received: from [87.69.77.57] (port=1613 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ293-0005pY-7m; Fri, 04 Mar 2022 02:14:33 -0500 In-Reply-To: <87tucewgu7.fsf@red-bean.com> (message from Karl Fogel on Thu, 03 Mar 2022 21:13:04 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286804 Archived-At: > From: Karl Fogel > Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org > Date: Thu, 03 Mar 2022 21:13:04 -0600 > > >> This looks correct to me. Thank you for the fix. I'm testing > >> it now on 'emacs-28' and 'master' (it should behave the same > >> on both, of course, but might as well make sure). Assuming it > >> behaves as expected, I'll apply using 'git patch' on the > >> emacs-28 branch. > > Please don't install new features on the release branch. > > This is a bugfix, not a new feature. The original message didn't describe any bugs, so I concluded it was a new feature. Sorry about that. However, if this is a bug, please tell: . what is the bug and how to reproduce it? . if this is a regression, what was the last Emacs version where the reproduction recipe worked correctly? > I re-read the "Branches" section in CONTRIBUTE before I posted -- > the relevant part is this, I think: > > > If you are fixing a bug that exists in the current release, > > you > > should generally commit it to the release branch; it will be > > merged > > to the master branch later by the gitmerge function. However, > > when > > the release branch is for Emacs version NN.2 and later, or > > when it > > is for Emacs version NN.1 that is in the very last stages of > > its > > pretest, that branch is considered to be in a feature freeze: > > only > > bug fixes that are "safe" or are fixing major problems should > > go to > > the release branch, the rest should be committed to the master > > branch. This is so to avoid destabilizing the next Emacs > > release. > > If you are unsure whether your bug fix is "safe" enough for > > the > > release branch, ask on the emacs-devel mailing list. > > That indicates that 'emacs-28' is the right branch for this > change. That branch is on version 28.0.91 right now, not 28.2 nor > late 28.1. How do you know whether the current pretest of 28.1 is or isn't "in the very latest stages of its pretest"? The text says to ask if you aren't sure. As things are, we are, I hope, in the very latest stages. > I'm happy to put this change on whatever branch you prefer, of > course. I will make up my mind after I know the answers to the above questions. > However, independent of this specific case, in general > how should one determine what branch to put something on, if the > guidance in CONTRIBUTE isn't enough? It's a judgment call. Which is why the text says to ask. Thanks.