unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org
Subject: Re: ./configure --enable-check-lisp-object-type
Date: Tue, 12 Apr 2022 22:05:45 +0300	[thread overview]
Message-ID: <83lewa3ywm.fsf@gnu.org> (raw)
In-Reply-To: <87zgkqb0ww.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue,  12 Apr 2022 20:40:31 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: monnier@iro.umontreal.ca,  akrl@sdf.org,  emacs-devel@gnu.org
> Date: Tue, 12 Apr 2022 20:40:31 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > And if you build without --enable-check-lisp-object-type, does it
> > compile cleanly with the additional braces?
> 
> Ah, no:
> 
> alloc.c:7847:8: warning: braces around scalar initializer
>  7847 |        4, 4, "watch_gc_cons_percentage", {0}, {0}}};
>       |        ^
> 
> 
> And similarly, the braces in DEFUN leads to:
> 
> xmenu.c:2773:1: note: in expansion of macro 'DEFUN'
>  2773 | DEFUN ("menu-or-popup-active-p", Fmenu_or_popup_active_p, Smenu_or_popup_active_p, 0, 0, 0,
>       | ^~~~~
> lisp.h:3178:16: note: (near initialization for 'Smenu_or_popup_active_p.s.command_modes')
> 
> in a non-enable-check build.

Which means we need 2 different initializations, conditioned on
CHECK_LISP_OBJECT_TYPE.



  reply	other threads:[~2022-04-12 19:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 16:58 ./configure --enable-check-lisp-object-type Lars Ingebrigtsen
2022-04-12 17:23 ` Stefan Monnier
2022-04-12 17:43   ` Eli Zaretskii
2022-04-12 18:27     ` Lars Ingebrigtsen
2022-04-12 18:34       ` Eli Zaretskii
2022-04-12 18:40         ` Lars Ingebrigtsen
2022-04-12 19:05           ` Eli Zaretskii [this message]
2022-04-12 22:20             ` Stefan Monnier
2022-04-13  8:47         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lewa3ywm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).