From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving Date: Mon, 09 May 2022 19:30:39 +0300 Message-ID: <83levau0r4.fsf@gnu.org> References: <165191796540.22789.3432288633082546349@vcs2.savannah.gnu.org> <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> <87fsli7uhf.fsf@gnus.org> <87bkw67rru.fsf@gnus.org> <8735hi7r7k.fsf@gnus.org> <87ilqe4roc.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 09 18:32:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no6It-00069W-W6 for ged-emacs-devel@m.gmane-mx.org; Mon, 09 May 2022 18:32:12 +0200 Original-Received: from localhost ([::1]:47374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no6Is-0004jd-Nf for ged-emacs-devel@m.gmane-mx.org; Mon, 09 May 2022 12:32:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no6HV-0003nT-4e for emacs-devel@gnu.org; Mon, 09 May 2022 12:30:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no6HU-0007t2-Mv; Mon, 09 May 2022 12:30:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AiwezHlGCVCk8PAj8WaB2HaPPpK7X/oKNB9d6v1jKRA=; b=T9O9J8JbQTnj VFp7MxeWNsCya6g62msNmyMoIbwO/97EV70WGrcv501Bno1pmTe2DotY1+ut0X9Se0Hck6C5T17y1 8oL3mcqG4ZVTOJPiSXcMA6A3K7wh+zXRPeeytQD7/+Jolqqev36XLlMjpA5YW24PGzKIwbqNDwyfj 7ubgb/s8hthZQ4l06l1x/nxTQwJeHvmEjPKlME6GtspZ+h7seXFOnel6FNSkYmP0TpJBZ8j4EUWvk 4UPBkDalNZXw1Yx6PMgsHcS5IDmOgsVDQDZpRyrCHKy4pIx8IUFCED+vgfXWBokodLHBQfYDQ3LMu NjuXTxd8/CCAAGYfJtlqQw==; Original-Received: from [87.69.77.57] (port=3210 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no6HT-00077i-Gz; Mon, 09 May 2022 12:30:44 -0400 In-Reply-To: <87ilqe4roc.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 09 May 2022 18:05:55 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289539 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org, Eli Zaretskii > Date: Mon, 09 May 2022 18:05:55 +0200 > > Stefan Monnier writes: > > > Maybe we could make `buffer-modified-p` return `autosaved` rather than > > `t` when the buffer is modified but auto-saved, and then > > have `restore-buffer-modified-p` accept such a value accordingly, yes. > > Unfortunately `buffer-modified-p' is documented to return t... Changing > that feels a bit "eh". (Which is why we should always say non-nil.) > > I don't think adding an extra call to `recent-auto-save-p' to the macro > would be that bad, but if people think altering the return value of > `buffer-modified-p' is OK, we can do that. Eli, what do you think? I don't see any Lisp comparing the return value to t, and only one place in C which might need some change due to this, so I think returning non-nil, non-t value from buffer-modified-p is a better way.