From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Proposed removal of struct frame->select_mini_window_flag.
Date: Wed, 18 May 2022 20:16:24 +0300 [thread overview]
Message-ID: <83leuyep7b.fsf@gnu.org> (raw)
In-Reply-To: <YoUm0V6xZFC0yWCc@ACM> (message from Alan Mackenzie on Wed, 18 May 2022 17:03:13 +0000)
> Date: Wed, 18 May 2022 17:03:13 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > sf->select_mini_window_flag = MINI_WINDOW_P (XWINDOW (sf->selected_window));
>
> > selected_frame = frame;
>
> > move_minibuffers_onto_frame (sf, for_deletion);
>
> > if (f->select_mini_window_flag
> > && !NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt)))
> > f->selected_window = f->minibuffer_window;
>
> Yes, I saw it.
>
> > How will this logic work without that flag?
>
> There is no logic which uses it.
How do you mean "no logic"? I mean this logic, right there:
if (f->select_mini_window_flag
&& !NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt)))
f->selected_window = f->minibuffer_window;
> These lines in frame.c set the flag in
> sf (the old frame), and test it in f (the new frame). It is intended to
> be a durable flag saying whether or not the mini-window in a non-selected
> frame is to be selected at the next do_switch_frame () into it. This
> might make sense if there were something setting f->selected_window without
> going through the proper functions.
The code above does just that, does it not? It directly sets
f->selected_window.
> What we do have is the setting of the flag unconditionally to false in
> select_window (window.c), with no attempt being made to save and restore
> the current value. Considering that Fselect_window can be called from
> gui_consider_frame_title (xdisp.c) during a redisplay (with the current
> bug fix), this means the flag can be initialised to false asynchronously
> at any time.
What do you mean by "asynchronously"? gui_consider_frame_title is not
called asynchronously, at least under my interpretation of that term.
prev parent reply other threads:[~2022-05-18 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 15:56 Proposed removal of struct frame->select_mini_window_flag Alan Mackenzie
2022-05-18 16:19 ` Eli Zaretskii
2022-05-18 17:03 ` Alan Mackenzie
2022-05-18 17:16 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83leuyep7b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).