From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 20:05:20 +0300 Message-ID: <83ler5u0fj.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <83bks3vtf5.fsf@gnu.org> <83tu5uug68.fsf@gnu.org> <86o7w1zniw.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, larsi@gnus.org, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:12:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4mR-0001Fy-Kr for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:12:03 +0200 Original-Received: from localhost ([::1]:46974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4mN-0007b1-Nk for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:11:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4fa-0000qQ-VB for emacs-devel@gnu.org; Tue, 30 Aug 2022 13:04:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4fa-000227-20; Tue, 30 Aug 2022 13:04:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pjB94YfoAfnVaio+etpYzifhVA1uU1iyFsY0Bag6K5E=; b=Ri3SwKM7eaIt WDuPgzhcGmLPxiAYRhqHw9WEzDESYZFWAmSLuIF3Z7WMug3O9mhicVUXOmi+nIF328KJ9H6mijh/n usZR+Gf6BDdBipDzokm8bJdcs1vaOMFpq1CE6/iC/0DrxRfIRrgEOG3cuBSR/+xQQoRzxFE8TDSAl lfwjm3yf74Qn7CANqtU+34WkdGuFZxHKGsfUs/9WCzLIN3dfxsnjVX3buuR3W7cz1ADKlWLW9V5+9 H3Fwhng6OUOSAW8wedBRCUOCMsi7g6QWFU5D31uzVCiPnbjRayaeO3f0n+LpQB061KOHq8PS845uV 5f8tW+0o2JUUQEXa+wTePg==; Original-Received: from [87.69.77.57] (port=3034 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4fY-0004GI-9C; Tue, 30 Aug 2022 13:04:57 -0400 In-Reply-To: <86o7w1zniw.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 30 Aug 2022 19:47:35 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294365 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org > Date: Tue, 30 Aug 2022 19:47:35 +0300 > > >> But even if we initially only support this in otherwise clean trees, > >> it will be a huge advantage vs the current situation, where this > >> feature is simply not available. > > > > Will the advantage be significant? I really have to ask, because IME > > applying an external patch and them committing the files as a whole never > > felt particularly painful before (aside from resolving any conflicts or > > corrupted whitespace, which the new feature doesn't help with). > > Indeed, just 'M-! git apply' before using 'vc-checkin-patch' will do the job > in case of an external patch. Unless some of the hunks are wrong or produce conflicts or are rejected due to 1001 reasons. Which is exactly the use case I thought this enabled. Sorry for misreading.