From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: struct face question Date: Fri, 16 Sep 2022 09:49:38 +0300 Message-ID: <83leqj4xvh.fsf@gnu.org> References: <87o7vfx4ni.fsf.ref@yahoo.com> <87o7vfx4ni.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 16 08:52:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ5Ct-0007n8-P5 for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 08:52:11 +0200 Original-Received: from localhost ([::1]:53208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ5Cs-0001ry-AO for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 02:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ5Ab-00015N-4K for emacs-devel@gnu.org; Fri, 16 Sep 2022 02:49:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ5Aa-0003QU-Ro; Fri, 16 Sep 2022 02:49:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fwsZ8wdvhAsA0K7C+dvhFlO+oPoQ75KdlqUcYIP4vx8=; b=G+OnkAYNYDvL Zm8NLOMp7IsN2LKRO+g6QQ5OPMOvv8o6omoeoj6YxiW6J+hAiLlx4Jd5Tc3tfX4ryvn+wvB3j1qHh B3el5w3w+zPacVztyJNlEyUyqWoBwPRn2ahscX1K90h8/k9LZUkbJgOvoyts1Aa5YYN75TWVQGE98 NMEf4ql01iKOTMZwntpEUnXo/BYHMBPYBi+dJWi8WgMhF6vAqFgGHhZKbrkLyYZo4AhhXzydFqMK5 2dis1T0EUfHPYDwjQ7zHNMplkFAIWFbs6kBfJo6wj2ghMV35VeCHLyz3XyPLrvwd6QpHAvq3FUf7f IqKmuUl/2AvC1vEIV1V1xQ==; Original-Received: from [87.69.77.57] (port=1700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ5AY-0005Xs-F1; Fri, 16 Sep 2022 02:49:48 -0400 In-Reply-To: <87o7vfx4ni.fsf@yahoo.com> (message from Po Lu on Fri, 16 Sep 2022 13:35:45 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295456 Archived-At: > From: Po Lu > Date: Fri, 16 Sep 2022 13:35:45 +0800 > > Is it ever valid for face->fontset to be -1? Yes, I think so. It means there's no fontset for this face. Which is normal when there's no font. > The X font backend doesn't > support scaling fonts, so displaying the separator-line face fails to > find a font with height 0.1, causing the following part of > realize_gui_face to be called: > > else > { > face->font = NULL; > face->fontset = -1; > } > > leading to face_for_char aborting from face->fontset being -1 later on. Please show a full backtrace from the crash, and preferably also a reproducer. What character are we trying to display in that case? If indeed the X font backend doesn't support that, it would perhaps call for a different definition of the face, but I'd like to understand the issue better before we decide how to solve it. Thanks.