From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Tue, 25 Apr 2023 20:02:04 +0300 Message-ID: <83leifvqsz.fsf@gnu.org> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> <838regwcnt.fsf@gnu.org> <87fs8o9spe.fsf@gmail.com> <835y9kw5ix.fsf@gnu.org> <86h6t3rjl8.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 25 19:03:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prM4S-0002IT-28 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Apr 2023 19:03:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prM3W-000403-TK; Tue, 25 Apr 2023 13:02:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prM3U-0003ws-1a for emacs-devel@gnu.org; Tue, 25 Apr 2023 13:02:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prM3S-0005MX-NT; Tue, 25 Apr 2023 13:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xsj3zu70EhR5z4WojeaCWbJtZ31pwOu8GkyuRiNUA4Q=; b=pkibl4S8W5oS iAoKdjF3USDpU+4nv1FrYp9lBeOcldXWTYrNpSptMqPVMTLjMIQwWmlXUdI3V3arKm24smibm+dCk CC+97I/OqWIqYdm1Ejmkj7Tv6+xR8GSlU12qM+uSpYyVb22FpPm8y0hnzR+XD+d21rnIFbg6P03qs 4iTcrysdgwCNJbYIHsX9c/aDAs1ByFVNJr2YrkQVocRC1U6cO2X//USvt4SKAyXz3HkvTSkqHa1zD SpCmpBFPzGebzxiA6G5wGLgPa7lGocjAiKA0IoFWwh0H13m011ydyeQcoQ8oKziU7BY6AgOCDObtA GFAtQIjmwN1Nsm8ttsUVOQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prM3M-0004r4-Pe; Tue, 25 Apr 2023 13:02:14 -0400 In-Reply-To: <86h6t3rjl8.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 25 Apr 2023 19:51:31 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305664 Archived-At: > From: Juri Linkov > Cc: Robert Pluim , michael_heerdegen@web.de, > emacs-devel@gnu.org, orontee@gmail.com > Date: Tue, 25 Apr 2023 19:51:31 +0300 > > >> >> This code and the defcustom is new in emacs-29, so we can still change > >> >> it to be a predicate instead. At least we should document is better > >> > >> Eli> Agreed. Patches welcome. > >> > >> I assumed you were agreeing to the code change, which looks like this: > > > > No objections, unless some code is already using this with a function > > that doesn't return a boolean. > > > > Matthias, Juri: any objections or comments? > > I guess the decision was delegated to the users > because there is a choice what to do with the outline. > Beside 'outline-hide-entry', there is also 'outline-show-branches' > used by 'subtree-is-long' and 'subtree-has-long-lines'. > > So I see no reason to remove 'custom-function'. > What could be done instead is to add a new choice > 'custom-predicate'. The suggestion is not to remove custom-function. The suggestion is to require that the function returns a boolean, to mean whether to hide or not to hide a heading, instead of requesting that the function itself hides/unhides the headings. What is the purpose of requesting a custom function to actually hide/unhide the headings, i.e. to know enough about the structure and internal details of Outline mode to do its job?