From: Eli Zaretskii <eliz@gnu.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: lekktu@gmail.com, merlyn@stonehenge.com, emacs-devel@gnu.org
Subject: Re: recent commit broke src/dired.c on OSX
Date: Sun, 25 Jul 2010 23:59:39 +0300 [thread overview]
Message-ID: <83k4ojb7lw.fsf@gnu.org> (raw)
In-Reply-To: <yxqlj8zb80l.fsf@fencepost.gnu.org>
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Sun, 25 Jul 2010 16:50:50 -0400
> Cc: emacs-devel@gnu.org, "Randal L. Schwartz" <merlyn@stonehenge.com>
>
> >> char *
> >> getcwd(char *buf, size_t size);
> >
> > This is already fixed on the trunk, assuming that in your build
> > environment HAVE_GETCWD is set.
>
> If HAVE_GETCWD is set there should not be a need to have a prototype,
> better just include unistd.h in that case.
>
> IMHO we should get rid of all such extern declarations, and just
> include the corresponding header files.
100% agreement.
next prev parent reply other threads:[~2010-07-25 20:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 17:23 recent commit broke src/dired.c on OSX Randal L. Schwartz
2010-07-25 17:30 ` Juanma Barranquero
2010-07-25 17:40 ` Randal L. Schwartz
2010-07-25 17:51 ` Juanma Barranquero
2010-07-25 17:58 ` Randal L. Schwartz
2010-07-25 18:04 ` Juanma Barranquero
2010-07-25 20:12 ` Chad Brown
2010-07-25 20:39 ` Juanma Barranquero
2010-07-26 2:46 ` Chad Brown
2010-07-26 3:12 ` Chad Brown
2010-07-26 3:43 ` Juanma Barranquero
2010-07-26 8:44 ` David Kastrup
2010-07-26 9:58 ` Juanma Barranquero
2010-07-26 6:02 ` Jan Djärv
2010-07-26 6:33 ` Jan Djärv
2010-07-26 16:58 ` Eli Zaretskii
2010-07-27 21:40 ` Chad Brown
2010-07-27 23:18 ` Juanma Barranquero
2010-07-27 23:28 ` Óscar Fuentes
2010-07-28 0:16 ` Juanma Barranquero
2010-07-28 0:33 ` Óscar Fuentes
2010-07-28 0:45 ` Juanma Barranquero
2010-07-28 0:54 ` Óscar Fuentes
2010-07-28 0:58 ` Juanma Barranquero
2010-07-28 6:32 ` Jan Djärv
2010-07-25 20:44 ` Eli Zaretskii
2010-07-29 18:21 ` Randal L. Schwartz
2010-07-29 19:11 ` Jan Djärv
2010-07-29 19:19 ` Randal L. Schwartz
2010-07-29 19:29 ` Chad Brown
2010-07-29 20:09 ` Jan Djärv
2010-07-29 20:37 ` Óscar Fuentes
2010-07-29 21:07 ` Jan Djärv
2010-07-29 21:17 ` Óscar Fuentes
2010-07-29 23:19 ` Chad Brown
2010-07-25 20:50 ` Dan Nicolaescu
2010-07-25 20:54 ` Juanma Barranquero
2010-07-25 20:59 ` Eli Zaretskii [this message]
2010-07-25 21:26 ` Jan Djärv
2010-07-25 21:32 ` Jan Djärv
2010-07-25 17:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k4ojb7lw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).