unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Set the version number in the texinfo manuals using configure
@ 2010-10-09  9:58 Eli Zaretskii
  2010-10-09 18:08 ` Glenn Morris
  2010-10-24 19:59 ` Jay Belanger
  0 siblings, 2 replies; 26+ messages in thread
From: Eli Zaretskii @ 2010-10-09  9:58 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

IMO, the changes introduced with revno 101857 do more trouble than
the problem they are supposed to solve.

I understand the need to ease the maintenance burden, and support the
measures to do so.  But I think the means chosen in this case are not
well thought out, to say the least.  For starters, this breaks the
Windows build:

  make[1]: Entering directory `D:/gnu/bzr/emacs/trunk/doc/emacs'
  makeinfo --force emacs.texi
  emacs.texi:8: @include `emacsver.texi': No such file or directory.
  emacs.texi:32: warning: undefined flag: EMACSVER.
  emacs.texi:102: warning: undefined flag: EMACSVER.
  emacs.texi:113: warning: undefined flag: EMACSVER.
  D:\gnu\bzr\emacs\trunk\doc\emacs//anti.texi:12: warning: undefined flag: EMACSVER.
  make[1]: *** [../../info/emacs] Error 1
  make[1]: Leaving directory `D:/gnu/bzr/emacs/trunk/doc/emacs'
  make: *** [info-gmake] Error 2

What's worse, I don't know how to solve this cleanly without requiring
the end users to have a port of Sed installed.  That's because the way
emacsver.texi gets created is by using a string generated by the
configure script that edits src/emacs.c with Sed.

More importantly, I don't understand what is the plan here.  Are we
going to introduce similar handling into all the other places where
the version string is used?  If not, why bother with this one alone,
when we already have a Lisp program to update them all when a release
is tarred?

If we are going to do something similar in other places, then let's
devise a machinery that could be easily ported to non-Posix platforms,
because at least some of these places are specific to those platforms.
Such changes should be at least discussed first and the blueprints
posted, to make sure all the aspects are understood and solutions
exists on all supported platforms.

I actually don't understand what's wrong with admin/admin.el that
requires to change the way we set version strings in the files that
need it.  If there are any disadvantages in admin.el, can they be
spelled out, please?

In addition, these changes have 2 smaller problems:

 . the file emacsver.texi.in violates the file-name restrictions on
   DOS filesystems, so it should be renamed to something like
   emacsver.in

 . the changes remove the arch-tag from several files -- what is the
   story here?



^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2010-10-31 15:17 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-09  9:58 Set the version number in the texinfo manuals using configure Eli Zaretskii
2010-10-09 18:08 ` Glenn Morris
2010-10-09 21:48   ` Eli Zaretskii
2010-10-24 19:59 ` Jay Belanger
2010-10-24 21:38   ` Eli Zaretskii
2010-10-24 21:59     ` Jay Belanger
2010-10-30  8:30     ` martin rudalics
2010-10-30 13:16       ` Eli Zaretskii
2010-10-30 14:49         ` martin rudalics
2010-10-30 15:27           ` Eli Zaretskii
2010-10-30 17:01             ` martin rudalics
2010-10-30 17:15               ` Eli Zaretskii
2010-10-30 17:57                 ` martin rudalics
2010-10-30 19:42                   ` Eli Zaretskii
2010-10-30 20:50                     ` martin rudalics
2010-10-30 21:10                       ` Eli Zaretskii
2010-10-30 21:20                         ` Jay Belanger
2010-10-30 22:02                           ` Eli Zaretskii
     [not found]                         ` <4CCC9EF8.9040507@gmx.at>
2010-10-31  3:59                           ` Eli Zaretskii
2010-10-31  8:18                             ` martin rudalics
2010-10-31 11:04                               ` Eli Zaretskii
2010-10-31 11:26                                 ` martin rudalics
2010-10-31 11:56                                   ` Juanma Barranquero
2010-10-31 13:09                                     ` Eli Zaretskii
2010-10-31 13:27                                       ` Juanma Barranquero
2010-10-31 15:17                                         ` martin rudalics

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).