unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 8545@debbugs.gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: issues with recent doprnt-related changes
Date: Fri, 06 May 2011 22:57:30 +0300	[thread overview]
Message-ID: <83k4e3lhzp.fsf@gnu.org> (raw)
In-Reply-To: <jwv8vuj21q0.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: eggert@cs.ucla.edu,  8545@debbugs.gnu.org,  emacs-devel@gnu.org
> Date: Fri, 06 May 2011 14:13:06 -0300
> 
> note that "the position of the nul byte" is the same as "the length
> of the list", so it's still <= MOST_POSITIVE_FIXNUM.  It's only the
> position after the nul byte that would overflow.

But what about this code and its commentary (from
next_element_from_c_string):

  /* IT's position can be greater IT->string_nchars in case a field
     width or precision has been specified when the iterator was
     initialized.  */
  if (IT_CHARPOS (*it) >= it->end_charpos)
    {
      /* End of the game.  */
      ...

This happens when the iterator is initialized by reseat_to_string.
Admittedly, it's not very practical to have such huge strings that are
padded to an even larger width...



  reply	other threads:[~2011-05-06 19:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DB50AB9.6060100@cs.ucla.edu>
     [not found] ` <83tydmaeo3.fsf@gnu.org>
     [not found]   ` <4DB65FF1.5010003@cs.ucla.edu>
     [not found]     ` <83aafb8p4a.fsf@gnu.org>
     [not found]       ` <4DB8ABEA.3080503@cs.ucla.edu>
     [not found]         ` <E1QFK7p-0000de-I3@fencepost.gnu.org>
     [not found]           ` <4DB9146D.2040702@cs.ucla.edu>
     [not found]             ` <E1QFQVO-0004Dq-6o@fencepost.gnu.org>
     [not found]               ` <4DB9E5FF.9020506@cs.ucla.edu>
     [not found]                 ` <83d3k571ee.fsf@gnu.org>
     [not found]                   ` <4DC10012.8020809@cs.ucla.edu>
     [not found]                     ` <E1QHYkc-0008Ip-Tq@fencepost.gnu.org>
2011-05-04 14:56                       ` issues with recent doprnt-related changes Paul Eggert
2011-05-05 20:36                         ` Eli Zaretskii
2011-05-06 13:33                           ` Stefan Monnier
2011-05-06 14:41                             ` Paul Eggert
2011-05-06 15:03                             ` Eli Zaretskii
2011-05-06 17:13                               ` Stefan Monnier
2011-05-06 19:57                                 ` Eli Zaretskii [this message]
2011-05-07  3:18                                   ` Stefan Monnier
2011-05-07  7:55                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k4e3lhzp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=8545@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).