From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 5/9] Prevent crash if w32 used before it's initialized Date: Tue, 07 Aug 2012 21:11:26 +0300 Message-ID: <83k3xafu7l.fsf@gnu.org> References: <3cb1f39b5711d712c2ec79d6a578044b1b432149.1344326992.git.dancol@dancol.org> <83pq72fwga.fsf@gnu.org> <50215028.4070708@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1344363096 4412 80.91.229.3 (7 Aug 2012 18:11:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 18:11:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 20:11:36 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyoFg-0001uK-CX for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 20:11:32 +0200 Original-Received: from localhost ([::1]:39060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyoFf-00079u-KD for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 14:11:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyoFd-00079d-Af for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:11:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyoFc-0007F4-6N for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:11:29 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyoFb-0007CJ-Ux for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:11:28 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8E00900CRH8G00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Tue, 07 Aug 2012 21:11:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8E009HVD728520@a-mtaout20.012.net.il>; Tue, 07 Aug 2012 21:11:26 +0300 (IDT) In-reply-to: <50215028.4070708@dancol.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152276 Archived-At: > Date: Tue, 07 Aug 2012 10:28:08 -0700 > From: Daniel Colascione > CC: emacs-devel@gnu.org > > >> for (dpyinfo = &one_w32_display_info, names = w32_display_name_list; > >> - dpyinfo; > >> + dpyinfo && !NILP (w32_display_name_list); > >> dpyinfo = dpyinfo->next, names = XCDR (names)) > >> { > >> Lisp_Object tem; > > > > Is this a real problem with the native w32 build? If so, can you tell > > how to reproduce it? > > No --- it's something that came up in my testing late last year, and > I've forgotten the exact circumstances of the problem now. The change > seems harmless enough though. Then please go ahead and commit it. Thanks.