From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Added basic file system watching support. Date: Mon, 01 Oct 2012 09:24:39 +0200 Message-ID: <83k3vad58o.fsf@gnu.org> References: <6218185.ViukoKRdFp@descartes> <1604303.YKOVcvQH0F@descartes> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1349076305 1515 80.91.229.3 (1 Oct 2012 07:25:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 07:25:05 +0000 (UTC) Cc: ruediger@c-plusplus.de, sdl.web@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 01 09:25:06 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIaNG-0004HR-3q for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 09:25:06 +0200 Original-Received: from localhost ([::1]:42214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIaNA-0005wI-Kq for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 03:25:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIaN3-0005vy-H3 for emacs-devel@gnu.org; Mon, 01 Oct 2012 03:24:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIaMy-0001Al-RI for emacs-devel@gnu.org; Mon, 01 Oct 2012 03:24:53 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIaMy-0001AR-JN for emacs-devel@gnu.org; Mon, 01 Oct 2012 03:24:48 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MB700C00DV9SD00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Mon, 01 Oct 2012 09:24:33 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MB700CP5DWXCU70@a-mtaout22.012.net.il>; Mon, 01 Oct 2012 09:24:33 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153805 Archived-At: > From: Stefan Monnier > Date: Mon, 01 Oct 2012 00:38:09 -0400 > Cc: Leo , emacs-devel@gnu.org > > >> I'm not very familiar with inotify and other file-system watching > >> facilities, so just as a guideline for others's reviews: I'm OK with > >> installing in 24.3 a non-complete version of the code, and I'm OK to > >> install before the freeze a code that needs more testing, *but* only if > >> those missing functionalities and testing won't require a redesign of > >> the API. > > It could require a minor redesign of the API. > > I know of "minor changes" (where backward compatibility is easy to > preserve) and "redesigns" but I don't know what a "minor redesign" would > look like. > > > At least I want to gather some experience using the API first. > > And maybe porting it to other systems will require API adjustments. > > Both BSD's and Windows' filesystem watch APIs are not as powerful > > as inotify. > > [ I'm probably rehashing something already discussed at the time. ] > If the API is sufficiently general that it can be reused for other > systems, that's great. Perhaps the API could be spelled out here, then this question could be answered for systems without inotify.