From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bidi reordering engine upgraded Date: Sat, 18 Oct 2014 15:54:15 +0300 Message-ID: <83k33xedxk.fsf@gnu.org> References: <834mv55quj.fsf@gnu.org> <543E9122.6070605@yandex.ru> <8338ap5o7l.fsf@gnu.org> <543E9A1C.2010904@yandex.ru> <831tq95m6x.fsf@gnu.org> <83zjcx450f.fsf@gnu.org> <83y4sh43zq.fsf@gnu.org> <543F41C9.3000507@yandex.ru> <83oatc4gz3.fsf@gnu.org> <1D1BD06B-BCE5-44A0-8F9D-4A7F0DF41504@swipnet.se> <83mw8u1qn8.fsf@gnu.org> <29ADC056-D9F9-461C-9D2E-D7F4AC5EE72F@swipnet.se> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1413636891 26731 80.91.229.3 (18 Oct 2014 12:54:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Oct 2014 12:54:51 +0000 (UTC) Cc: dmantipov@yandex.ru, emacs-devel@gnu.org To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 18 14:54:45 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XfTWu-0001Ei-Sx for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2014 14:54:45 +0200 Original-Received: from localhost ([::1]:36598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfTWu-0004Uh-Co for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2014 08:54:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfTWm-0004TP-Ok for emacs-devel@gnu.org; Sat, 18 Oct 2014 08:54:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XfTWh-0000nJ-Oy for emacs-devel@gnu.org; Sat, 18 Oct 2014 08:54:36 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:32786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfTWh-0000mM-Gj for emacs-devel@gnu.org; Sat, 18 Oct 2014 08:54:31 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NDN0070045PN200@mtaout29.012.net.il> for emacs-devel@gnu.org; Sat, 18 Oct 2014 15:53:25 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NDN00ADM551R700@mtaout29.012.net.il>; Sat, 18 Oct 2014 15:53:25 +0300 (IDT) In-reply-to: <29ADC056-D9F9-461C-9D2E-D7F4AC5EE72F@swipnet.se> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.185 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175536 Archived-At: > From: Jan Dj=E4rv > Date: Sat, 18 Oct 2014 14:34:06 +0200 > Cc: dmantipov@yandex.ru, > emacs-devel@gnu.org >=20 > > /* Compute frame-relative coordinates for phys cursor. */ > > get_phys_cursor_geometry (w, row, cursor_glyph, &x, &y, &h); > > - wd =3D w->phys_cursor_width; > > + wd =3D w->phys_cursor_width - 1; >=20 > Are we sure this never becomes negative? If it does, we already have that problem, since previously, the subtraction of 1 was done in get_phys_cursor_geometry. > I suggest you check it in so we can test it. OK, will do. > Do we have a test case? Yes, the one posted by Dmitry here: http://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00518.html