unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs trunk crash
Date: Wed, 25 Mar 2015 22:38:07 +0200	[thread overview]
Message-ID: <83k2y4olsg.fsf@gnu.org> (raw)
In-Reply-To: <CAFgFV9N8auU_d9g06ZKGEXhmUNc6Xcu=4YEw-hS1KJNVJ4VQJQ@mail.gmail.com>

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Tue, 24 Mar 2015 22:10:16 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> The file is attached.
> Put the point at the beginning of the second line on the bracket
> and M-: (read (current-buffer))

Try the patch below.  It solves the crash with the file you sent, but
the question is: does it also solve your real-life use case?

diff --git a/src/lread.c b/src/lread.c
index ae17529..050e43e 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -3280,7 +3280,7 @@ BUFFER is the buffer to evaluate (nil means use current buffer).
     {
     case Lisp_Vectorlike:
       {
-	ptrdiff_t i, length = 0;
+	ptrdiff_t i = 0, length = 0;
 	if (BOOL_VECTOR_P (subtree))
 	  return subtree;		/* No sub-objects anyway.  */
 	else if (CHAR_TABLE_P (subtree) || SUB_CHAR_TABLE_P (subtree)
@@ -3295,7 +3295,9 @@ BUFFER is the buffer to evaluate (nil means use current buffer).
 	     behavior.  */
 	  wrong_type_argument (Qsequencep, subtree);
 
-	for (i = 0; i < length; i++)
+	if (SUB_CHAR_TABLE_P (subtree))
+	  i = 2;
+	for ( ; i < length; i++)
 	  SUBSTITUTE (AREF (subtree, i),
 		      ASET (subtree, i, true_value));
 	return subtree;



  reply	other threads:[~2015-03-25 20:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 23:21 Emacs trunk crash Fabrice Popineau
2015-03-21  8:14 ` Eli Zaretskii
2015-03-22 19:59   ` Fabrice Popineau
2015-03-22 20:13     ` Eli Zaretskii
2015-03-22 20:22     ` Eli Zaretskii
2015-03-22 20:28       ` Eli Zaretskii
2015-03-22 22:35         ` Stefan Monnier
2015-03-23 15:33           ` Eli Zaretskii
2015-03-22 22:37       ` Fabrice Popineau
2015-03-23  5:32         ` Fabrice Popineau
2015-03-23 15:34           ` Eli Zaretskii
2015-03-23 20:55             ` Fabrice Popineau
2015-03-23 21:27               ` Fabrice Popineau
2015-03-24  2:28                 ` Stefan Monnier
2015-03-24 17:23               ` Eli Zaretskii
2015-03-24 21:10                 ` Fabrice Popineau
2015-03-25 20:38                   ` Eli Zaretskii [this message]
     [not found]                     ` <CAFgFV9MVLXraWXyVGw5=y3QWRK_5DyGf=0G6DrMLsO6gwFHSGA@mail.gmail.com>
     [not found]                       ` <837fu2bwd3.fsf@gnu.org>
2015-03-27 10:41                         ` Fabrice Popineau
2015-03-27 13:18                           ` Eli Zaretskii
2015-03-21  9:59 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2y4olsg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=fabrice.popineau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).