From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member Date: Tue, 13 Oct 2015 05:42:47 +0300 Message-ID: <83k2qro5eg.fsf@gnu.org> References: <20151012170324.17966.77@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1444704184 22050 80.91.229.3 (13 Oct 2015 02:43:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 02:43:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 13 04:42:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZlpYF-0002Vw-8o for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 04:42:55 +0200 Original-Received: from localhost ([::1]:60034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlpYE-0005kB-D5 for ged-emacs-devel@m.gmane.org; Mon, 12 Oct 2015 22:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlpY2-0005k0-7Z for emacs-devel@gnu.org; Mon, 12 Oct 2015 22:42:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlpXx-0000n7-9k for emacs-devel@gnu.org; Mon, 12 Oct 2015 22:42:42 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:44428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlpXx-0000n0-1a for emacs-devel@gnu.org; Mon, 12 Oct 2015 22:42:37 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NW500G000CWTV00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Tue, 13 Oct 2015 05:42:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW500GMO0UZNU80@a-mtaout20.012.net.il>; Tue, 13 Oct 2015 05:42:35 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191423 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Mon, 12 Oct 2015 21:07:00 -0400 > > > Attempt to avoid crashes in plist-member > > > * src/fns.c (Fplist_member): Don't call QUIT between a CONSP test > > and a call to XCDR. (Bug#21655) > > I have no objection to the patch itself, but I must say that I wonder > how it can avoid crashes. IOW why would calling QUIT between a CONSP test > and a call to XCDR be dangerous? QUIT could call some Lisp. How else would you explain a segfault in that loop?