From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Thu, 19 Nov 2015 18:27:55 +0200 Message-ID: <83k2pe7y44.fsf@gnu.org> References: <877flswse5.fsf@lifelogs.com> <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> <564DF0F6.5060501@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1447950568 3703 80.91.229.3 (19 Nov 2015 16:29:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 16:29:28 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 17:29:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzS59-0007WJ-OE for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 17:29:11 +0100 Original-Received: from localhost ([::1]:42775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzS58-0002d0-Um for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 11:29:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzS4I-0001qZ-1n for emacs-devel@gnu.org; Thu, 19 Nov 2015 11:28:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzS4C-0002cY-Bu for emacs-devel@gnu.org; Thu, 19 Nov 2015 11:28:17 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:34705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzS4C-0002c8-43 for emacs-devel@gnu.org; Thu, 19 Nov 2015 11:28:12 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NY200400L79YW00@mtaout27.012.net.il> for emacs-devel@gnu.org; Thu, 19 Nov 2015 18:23:10 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY200K7FLILJQ90@mtaout27.012.net.il>; Thu, 19 Nov 2015 18:23:10 +0200 (IST) In-reply-to: <564DF0F6.5060501@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194795 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Thu, 19 Nov 2015 07:55:34 -0800 > > The main thing I noticed (that was not already in your list or in my > upcoming changes) are some problems in memory allocation. The module > code calls malloc directly, instead of xmalloc, for reasons I don't > understand. I suspect the reason is the same that it doesn't call CHECK_NUMBER etc., but instead emulates that in its own code: the authors wanted to refrain from causing a non-local exit directly, they wanted such exits to go through their own non-local exit routine. But that's a guess. If this is indeed the reason, we should probably look for a better solution. > More generally, how should modules obtain memory in an > Emacs-friendly way? The code in module.c runs in Emacs, so I think it's friendly enough (apart of the xmalloc issue). Or did I misunderstand what you meant? > There are some other things I noticed which I'll try to summarize after > fixing the stuff that's easy to fix (missing copyright notices, > formatting, etc.). Thanks.