From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mode
Date: Mon, 28 Nov 2016 17:51:34 +0200 [thread overview]
Message-ID: <83k2bnzjp5.fsf@gnu.org> (raw)
Ping! I still think this patch should be moved to master.
> > > It's a very annoying and highly visible bug, and the fix is trivial and
> > cannot possibly break anything.
> >
> > It wasn't reported until now, was it? So I guess it's only visible
> > under some conditions that don't happen very often.
> >
> > It happens always when selecting text with the mouse in HTerm, I think that
> > happens very often. Perhaps
> > people just ignore the error message most of the time.
> Perhaps. But that probably means it isn't urgent to fix, especially
> if we had this with us for quite some time.
> > Can you tell since when do we have this bug? If it exists long
> > enough, I don't think we should do this on the release branch, it goes
> > against the criteria for bug fixes there.
> >
> > What are the criteria?
> As described here:
> http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html
> http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00460.html
> http://lists.gnu.org/archive/html/bug-gnu-emacs/2016-10/msg00787.html
> > CONTRIBUTE states
> > "Release branches […] are mainly
> > intended for more-conservative changes such as bug fixes. […]
> > If you are fixing a bug that exists in the current release, be sure to
> > commit it to the release branch; […]"
> That's a general policy, but Emacs 25.2 has special rules because we
> want to put it out the door very soon.
> > If the actual policy is different, please document it in CONTRIBUTE.
> I don't think it's right to publish ad-hoc criteria in CONTRIBUTE,
> that would be confusing to new contributors.
> > I've seen some talk about bugfix-only releases, but I think the policy should
> > be clearer and better documented
> > to avoid such discussions.
> I don't see any good alternative to reading the mailing lists, sorry.
next reply other threads:[~2016-11-28 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 15:51 Eli Zaretskii [this message]
2016-11-28 18:47 ` [Emacs-diffs] emacs-25 d4e1549: Guard terminal parameter in XTerm mode Philipp Stephani
2016-11-28 19:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2bnzjp5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).