unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: raman <raman@google.com>
Cc: politza@hochschule-trier.de, emacs-devel@gnu.org
Subject: Re: shell-unquote-argument: throws error if called outside a shell buffer
Date: Sun, 12 Mar 2017 17:17:06 +0200	[thread overview]
Message-ID: <83k27ucyod.fsf@gnu.org> (raw)
In-Reply-To: <p91bmt72osz.fsf@google.com> (message from raman on Sat, 11 Mar 2017 18:48:12 -0800)

> From: raman <raman@google.com>
> Date: Sat, 11 Mar 2017 18:48:12 -0800
> Cc: emacs-devel@gnu.org
> 
> Andreas Politz <politza@hochschule-trier.de> writes:
> Yes, namespacing -- plus incomplete documentation.
> shell-unquote-argument is a compiled Lisp function in `shell.el'.
> 
> (shell-unquote-argument STRING)
> 
> Remove all kinds of shell quoting from STRING.

I think this is simply a bug: the only reason that function wants a
shell buffer is to access the name of the shell process running in
it.  It could instead fall back on some system-dependent default, and
perhaps also provide a way for Lisp callers to specify the shell.

Patches to that effect are welcome.  (I'm also in favor of moving this
function to subr.el, while at that.)

TIA



      reply	other threads:[~2017-03-12 15:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 21:01 shell-unquote-argument: throws error if called outside a shell buffer raman
2017-03-11 23:10 ` Andreas Politz
2017-03-12  2:48   ` raman
2017-03-12 15:17     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k27ucyod.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=politza@hochschule-trier.de \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).