From: Eli Zaretskii <eliz@gnu.org>
To: "Elias Mårtenson" <lokedhs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: call-process blocks the active thread
Date: Fri, 08 Sep 2017 15:16:35 +0300 [thread overview]
Message-ID: <83k219xu58.fsf@gnu.org> (raw)
In-Reply-To: <CADtN0WKoEv9oEd_q8JNC0_xk47p41m7Q_6kMF1i_cNXjekzBjQ@mail.gmail.com> (message from Elias Mårtenson on Fri, 8 Sep 2017 18:36:17 +0800)
> From: Elias Mårtenson <lokedhs@gmail.com>
> Date: Fri, 8 Sep 2017 18:36:17 +0800
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> This is not a bug.
>
> I'm not entirely sure why you feel that distinction is important.
I thought you were reporting it as a bug, so it was important for me
to say Emacs was working as designed in this case.
> At the end of the day, it's ‘start-process’ that
> doesn't yield while the external process runs. Is there a reason why it can't be changed so that it does?
AFAIU, it would require significant changes in how call-process works,
both how it waits for the child process to exit and how it reads the
sub-process output. And start-process already has all that figured
out, so I think it's easier to just use it, especially since threading
already supports start-process, in that the calling thread will yield
automatically while it reads sub-process output and/or waits for it to
exit.
Of course, it's possible I don't see some clever way to make
call-process thread-aware, which is why I said that if someone has
concrete ideas for how to do that, they are encouraged to speak up.
next prev parent reply other threads:[~2017-09-08 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 3:00 call-process blocks the active thread Elias Mårtenson
2017-09-08 3:56 ` Eric Abrahamsen
2017-09-08 7:01 ` Eli Zaretskii
2017-09-08 7:45 ` Stefan Monnier
2017-09-08 8:06 ` Eli Zaretskii
2017-09-08 10:36 ` Elias Mårtenson
2017-09-08 11:27 ` Philipp Stephani
2017-09-08 12:16 ` Eli Zaretskii [this message]
2017-09-08 16:12 ` Tom Tromey
2017-09-08 18:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k219xu58.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lokedhs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).