From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: oleh@oremacs.com, eggert@cs.ucla.edu, monnier@iro.umontreal.ca,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like
Date: Thu, 05 Oct 2017 21:47:48 +0300 [thread overview]
Message-ID: <83k209whwr.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY0HLRCYV=Jj_kT-QRLEq_53UZyKCKykwaAL_LswbTyARQ@mail.gmail.com> (message from Kaushal Modi on Thu, 05 Oct 2017 17:08:06 +0000)
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Thu, 05 Oct 2017 17:08:06 +0000
> Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org, oleh@oremacs.com
>
> Is it possible this would cause the echo area to be 3-lines high? Also noticed that the hydra.el package is
> unusable after the latest build from emacs-26. My last good build was just before the commit related to
> format change.
>
> OK, I can now confirm that. Reverting just that commit[1] brings things back to normal.
Please always provide a minimal recipe to reproduce whatever problems
you see. For add-on packages, please also provide an explanation why
what you see is problematic. E.g., in this case, by just seeing the
echo-area messages, I don't quite understand the problem, as I don't
use hydra.
Some minimal details like that are always necessary to understand what
is the problem and how to fix it.
> So it should be reverted on emacs-26 for now?
We don't usually revert commits when they cause problems, we rather
prefer fixing the problems. I'm quite sure this one will be fixed
soon enough.
Thanks.
next prev parent reply other threads:[~2017-10-05 18:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171004214511.1405.22257@vcs0.savannah.gnu.org>
[not found] ` <20171004214513.6A40E2041C@vcs0.savannah.gnu.org>
2017-10-05 3:09 ` [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Stefan Monnier
2017-10-05 6:07 ` Paul Eggert
2017-10-05 7:30 ` Eli Zaretskii
2017-10-05 13:20 ` Stefan Monnier
2017-10-05 16:57 ` Kaushal Modi
2017-10-05 17:08 ` Kaushal Modi
2017-10-05 17:09 ` Kaushal Modi
2017-10-05 18:47 ` Eli Zaretskii [this message]
2017-10-05 20:13 ` Kaushal Modi
2017-10-05 21:44 ` Paul Eggert
2017-10-06 0:47 ` Kaushal Modi
2017-10-06 17:45 ` Paul Eggert
2017-10-06 17:49 ` Kaushal Modi
2017-10-06 18:06 ` Paul Eggert
2017-10-06 18:15 ` Kaushal Modi
2017-10-06 18:21 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k209whwr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=oleh@oremacs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).