make error on pinyin, leim,

make error on pinyin, leim,

[Colin Baxter]

After a pull from master, I get the make error:

Makefile:147: recipe for target '../lisp/language/pinyin.el' failed
make[3]: *** [../lisp/language/pinyin.el] Error 255
make[3]: Leaving directory '/home/redknight/git/emacs/leim'
Makefile:356: recipe for target 'leim' failed
make[2]: *** [leim] Error 2
make[2]: Leaving directory '/home/redknight/git/emacs/lisp'
Makefile:787: recipe for target '../lisp/loaddefs.el' failed
make[1]: *** [../lisp/loaddefs.el] Error 2
make[1]: Leaving directory '/home/redknight/git/emacs/src'
Makefile:423: recipe for target 'src' failed
make: *** [src] Error 2

I'm on 3.16.0-7-686-pae #1 SMP Debian 3.16.59-1 (2018-10-03) i686
GNU/Linux.

Best wishes,

Colin Baxter
m43cap@yandex.com

Re: make error on pinyin, leim,

[Stephen Berman]

On Mon, 25 Feb 2019 09:53:38 +0000 Colin Baxter <m43cap@yandex.com> wrote:

> After a pull from master, I get the make error:
>
> Makefile:147: recipe for target '../lisp/language/pinyin.el' failed
> make[3]: *** [../lisp/language/pinyin.el] Error 255
> make[3]: Leaving directory '/home/redknight/git/emacs/leim'
> Makefile:356: recipe for target 'leim' failed
> make[2]: *** [leim] Error 2
> make[2]: Leaving directory '/home/redknight/git/emacs/lisp'
> Makefile:787: recipe for target '../lisp/loaddefs.el' failed
> make[1]: *** [../lisp/loaddefs.el] Error 2
> make[1]: Leaving directory '/home/redknight/git/emacs/src'
> Makefile:423: recipe for target 'src' failed
> make: *** [src] Error 2

I got this too today.  I deleted the .elc files in lisp/international
and reinvoked make, and then the build succeeded.

Steve Berman

Re: make error on pinyin, leim,

[Colin Baxter]

Dear Steve,
>>>>> Stephen Berman <stephen.berman@gmx.net> writes:

    > On Mon, 25 Feb 2019 09:53:38 +0000 Colin Baxter <m43cap@yandex.com> wrote:
    >> After a pull from master, I get the make error:
    >> 
    >> Makefile:147: recipe for target '../lisp/language/pinyin.el'
    >> failed make[3]: *** [../lisp/language/pinyin.el] Error 255
    >> make[3]: Leaving directory '/home/redknight/git/emacs/leim'
    >> Makefile:356: recipe for target 'leim' failed make[2]: *** [leim]
    >> Error 2 make[2]: Leaving directory
    >> '/home/redknight/git/emacs/lisp' Makefile:787: recipe for target
    >> '../lisp/loaddefs.el' failed make[1]: *** [../lisp/loaddefs.el]
    >> Error 2 make[1]: Leaving directory
    >> '/home/redknight/git/emacs/src' Makefile:423: recipe for target
    >> 'src' failed make: *** [src] Error 2

    > I got this too today.  I deleted the .elc files in
    > lisp/international and reinvoked make, and then the build
    > succeeded.

Thanks for the advice, yes that works. Something to remember for the
future.

Best wishes,

Colin Baxter
m43cap@yandex.com

Re: make error on pinyin, leim,

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Mon, 25 Feb 2019 13:20:06 +0100
> Cc: emacs-devel@gnu.org
> 
> I got this too today.  I deleted the .elc files in lisp/international
> and reinvoked make, and then the build succeeded.

Deleting titdic-cnv.elc should be enough.  Interestingly, I saw the
error message, but the build did run to completion, compiling the
updated titdic-cnv, and then saying "make" one more time generated the
missing pinyin.el.

Re: make error on pinyin, leim,

[Eric Abrahamsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Mon, 25 Feb 2019 13:20:06 +0100
>> Cc: emacs-devel@gnu.org
>> 
>> I got this too today.  I deleted the .elc files in lisp/international
>> and reinvoked make, and then the build succeeded.
>
> Deleting titdic-cnv.elc should be enough.  Interestingly, I saw the
> error message, but the build did run to completion, compiling the
> updated titdic-cnv, and then saying "make" one more time generated the
> missing pinyin.el.

Bah, I hope that's not something I did wrong. That was my first stab at
messing with "make".

Re: make error on pinyin, leim,

[Eric Abrahamsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Stephen Berman <stephen.berman@gmx.net>
>>> Date: Mon, 25 Feb 2019 13:20:06 +0100
>>> Cc: emacs-devel@gnu.org
>>> 
>>> I got this too today.  I deleted the .elc files in lisp/international
>>> and reinvoked make, and then the build succeeded.
>>
>> Deleting titdic-cnv.elc should be enough.  Interestingly, I saw the
>> error message, but the build did run to completion, compiling the
>> updated titdic-cnv, and then saying "make" one more time generated the
>> missing pinyin.el.
>
> Bah, I hope that's not something I did wrong. That was my first stab at
> messing with "make".

I have to assume I did something wrong with the dependencies, since the
whole point of make is that it should detect that titdic-cnv.el (or
pinyin.el?) is out of date and recompile -- isn't it?

Re: make error on pinyin, leim,

[Eli Zaretskii]

> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Mon, 25 Feb 2019 13:22:41 -0800
> 
> I have to assume I did something wrong with the dependencies, since the
> whole point of make is that it should detect that titdic-cnv.el (or
> pinyin.el?) is out of date and recompile -- isn't it?

No, the dependencies are OK.  The problem is the old titdic-cnv.elc,
which doesn't include the new function required to produce pinyin.el,
and the fact that Emacs loads a .elc file in preference to the
corresponding .el file.  If anything is wrong, it's the fact that we
do "make all" in leim/ before we compile Lisp files in lisp/.  So it's
a one-time thing.

Re: make error on pinyin, leim,

[Eric Abrahamsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Mon, 25 Feb 2019 13:22:41 -0800
>> 
>> I have to assume I did something wrong with the dependencies, since the
>> whole point of make is that it should detect that titdic-cnv.el (or
>> pinyin.el?) is out of date and recompile -- isn't it?
>
> No, the dependencies are OK.  The problem is the old titdic-cnv.elc,
> which doesn't include the new function required to produce pinyin.el,
> and the fact that Emacs loads a .elc file in preference to the
> corresponding .el file.  If anything is wrong, it's the fact that we
> do "make all" in leim/ before we compile Lisp files in lisp/.  So it's
> a one-time thing.

Okay, thanks.

Re: make error on pinyin, leim,

[Stefan Monnier]

> No, the dependencies are OK.

[...]

> If anything is wrong, it's the fact that we do "make all" in leim/
> before we compile Lisp files in lisp/.

Hmm... indeed, if the leim Makefile had a dependency that forced
(re)compilation of titdic-cnv.el, then the problem would not happen.
So it is also a dependency problem.

> So it's a one-time thing.

And it's not the first/only/last quirk of our Makefiles, so indeed it's
not high-priority to fix it.


        Stefan